Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Environment.wraps signature now has correct arguments #67

Merged
merged 2 commits into from
Jan 13, 2024

Conversation

epignatelli
Copy link
Owner

No description provided.

@epignatelli epignatelli self-assigned this Jan 13, 2024
Copy link

github-actions bot commented Jan 13, 2024

************* Module helx._version
helx/_version.py:1:0: C0114: Missing module docstring (missing-module-docstring)
************* Module helx.base.mdp
helx/base/mdp.py:37:0: C0301: Line too long (105/100) (line-too-long)
helx/base/mdp.py:1:0: C0114: Missing module docstring (missing-module-docstring)
helx/base/mdp.py:31:0: C0115: Missing class docstring (missing-class-docstring)
************* Module helx.envs.environment
helx/envs/environment.py:31:0: C0115: Missing class docstring (missing-class-docstring)
helx/envs/environment.py:37:4: C0116: Missing function or method docstring (missing-function-docstring)
helx/envs/environment.py:44:4: C0116: Missing function or method docstring (missing-function-docstring)
helx/envs/environment.py:57:0: C0115: Missing class docstring (missing-class-docstring)
helx/envs/environment.py:61:4: C0116: Missing function or method docstring (missing-function-docstring)
helx/envs/environment.py:60:4: W4905: Using deprecated decorator abc.abstractclassmethod() (deprecated-decorator)
helx/envs/environment.py:64:4: C0116: Missing function or method docstring (missing-function-docstring)


Report
======
55 statements analysed.

Statistics by type
------------------

+---------+-------+-----------+-----------+------------+---------+
|type     |number |old number |difference |%documented |%badname |
+=========+=======+===========+===========+============+=========+
|module   |3      |NC         |NC         |33.33       |0.00     |
+---------+-------+-----------+-----------+------------+---------+
|class    |3      |NC         |NC         |0.00        |0.00     |
+---------+-------+-----------+-----------+------------+---------+
|method   |7      |NC         |NC         |42.86       |0.00     |
+---------+-------+-----------+-----------+------------+---------+
|function |0      |NC         |NC         |0           |0        |
+---------+-------+-----------+-----------+------------+---------+



External dependencies
---------------------
::

    helx 
      \-base 
        \-mdp (helx.envs.environment)
        \-spaces (helx.envs.environment)



126 lines have been analyzed

Raw metrics
-----------

+----------+-------+------+---------+-----------+
|type      |number |%     |previous |difference |
+==========+=======+======+=========+===========+
|code      |63     |50.00 |NC       |NC         |
+----------+-------+------+---------+-----------+
|docstring |9      |7.14  |NC       |NC         |
+----------+-------+------+---------+-----------+
|comment   |29     |23.02 |NC       |NC         |
+----------+-------+------+---------+-----------+
|empty     |25     |19.84 |NC       |NC         |
+----------+-------+------+---------+-----------+



Duplication
-----------

+-------------------------+------+---------+-----------+
|                         |now   |previous |difference |
+=========================+======+=========+===========+
|nb duplicated lines      |0     |NC       |NC         |
+-------------------------+------+---------+-----------+
|percent duplicated lines |0.000 |NC       |NC         |
+-------------------------+------+---------+-----------+



Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |10     |NC       |NC         |
+-----------+-------+---------+-----------+
|refactor   |0      |NC       |NC         |
+-----------+-------+---------+-----------+
|warning    |1      |NC       |NC         |
+-----------+-------+---------+-----------+
|error      |0      |NC       |NC         |
+-----------+-------+---------+-----------+



Messages
--------

+---------------------------+------------+
|message id                 |occurrences |
+===========================+============+
|missing-function-docstring |4           |
+---------------------------+------------+
|missing-class-docstring    |3           |
+---------------------------+------------+
|missing-module-docstring   |2           |
+---------------------------+------------+
|line-too-long              |1           |
+---------------------------+------------+
|deprecated-decorator       |1           |
+---------------------------+------------+




-----------------------------------
Your code has been rated at 8.00/10

@epignatelli epignatelli merged commit 15137bd into main Jan 13, 2024
1 of 2 checks passed
@epignatelli epignatelli deleted the fix-env-signature branch January 13, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant