Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency Container in a Nested Form #135

Open
alberto-bottarini opened this issue Oct 5, 2020 · 4 comments
Open

Dependency Container in a Nested Form #135

alberto-bottarini opened this issue Oct 5, 2020 · 4 comments

Comments

@alberto-bottarini
Copy link

Based on this cross-package issue yassilah/laravel-nova-nested-form#26, I created a fork of dependency-container where this problem is fixed.

It seems to working, but i would like to find someone that helps me in testing.
You can find fork here: https://github.com/alberto-bottarini/nova-dependency-container

container-nested
@sash
Copy link
Contributor

sash commented Oct 13, 2020

Can you please open a merge request! We are facing the same issue, and It would be great if the original component supports nested forms!

@alberto-bottarini
Copy link
Author

Can you help me testing the fork? I would like to propose a tested PR...

@alberto-bottarini alberto-bottarini mentioned this issue Nov 25, 2020
Open
@alberto-bottarini
Copy link
Author

@sash I created a PR.
Please upvote

#146

@smskin
Copy link
Collaborator

smskin commented Jan 30, 2022

The maintainer ignored PR too long. Code in pr 146 has conflicts. I fixed conflicts in PR 202 (#202). Pls upvote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sash @alberto-bottarini @smskin