Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of the realdisplaysizemm C-Extension #444

Merged
merged 34 commits into from
Oct 23, 2024
Merged

Get rid of the realdisplaysizemm C-Extension #444

merged 34 commits into from
Oct 23, 2024

Conversation

eoyilmaz
Copy link
Owner

Got rid of the C-Extension. Tested on MacOS, where it is working fine. Need more tests for other OSes before we merge this. Creating the PR just to start running the builds on GitHub.

@eoyilmaz
[#16] Add a new DisplayCAL.argyll module to collect all the Argyll …
deab1c0 
…related utility classes and functions.
@eoyilmaz
[#16] Added a new test module for DisplayCAL.argyll.
22fa7a6
@eoyilmaz
* [#16] Moved ArgyllCMS related utility functions to their own module…
9067de7 
… at `DisplayCAL.argyll`.
@eoyilmaz
* [#16] Initial prototype of C-Extension independent version of `Real…
8c260de 
…DisplaySizeMM` module. This needs a redesign and better implementation. But is a good proof of concept.
@eoyilmaz
* [#16] DisplayCAL.RealDisplaySizeMM.Display.from_dispwin_data() no…
17c5ad5 
…w uses regular expressions to extract the data.
@eoyilmaz
* [#16] Removed the extension build part from setup scripts.
cb1ff43
@eoyilmaz
- [#16] DisplayCAL.edid.get_edid() now uses xrandr commad output …
df66b02 
…to extract EDID data.

- [#16] Fixed `DisplayCAL.RealDisplaySizeMM.Display.from_dispwin_data()` to expect and use `bytes` data instead of `str`.
- [#16] Updated `DisplayCAL.RealDisplaySizeMM.get_dispwin_output()` to return `bytes` instead of `str` to match the rest of the application.
@eoyilmaz eoyilmaz linked an issue Oct 21, 2024 that may be closed by this pull request
Get rid of RealDisplaySizeMM C-Extension #16
Closed
@eoyilmaz
[#16] Dropped a comment about why we are using dispwin command with…
a61a2e1 
… `-d0` argument in `DisplayCAL.RealDisplaySizeMM`.
@eoyilmaz
[#16] Updated pytest.yml to output colors and run in parallel.
31a9ebd
@eoyilmaz
[#16] Updated DisplayCAL.edid.get_edid() to use the which utility…
1cfec78 
… to get the `xrandr` executable path under Linux.
@eoyilmaz
[#16] Added some debug prints for GitHub tests.
6b4dcbe
@eoyilmaz
[#16] Removed wxPython from setup.py for debugging purposes of Gi…
e2d6974 
…tHub actions.
@eoyilmaz
[#16] Fix typo in setup.py after fix for debugging purposes of GitH…
9b66ae9 
…ub actions.
@eoyilmaz
[#16] Removed wxPython from setup.cfg for debugging purposes of G…
9f45f47 
…itHub actions.
@eoyilmaz
[#16] Added some debug prints for GitHub tests (2).
bcdb5ac
@eoyilmaz
[#16] Fix typo in RealDisplaySizeMM.py after fix for debugging purp…
7438b34 
…oses of GitHub actions.
@eoyilmaz
[#16] Added some debug prints for GitHub tests (3).
936a62a
@eoyilmaz
[#16] Added some debug prints for GitHub tests (4).
4f85684
@eoyilmaz
[#16] Added some debug prints for GitHub tests (5).
3aa2dd4
@eoyilmaz
[#16] Added some debug prints for GitHub tests (6).
34e5618
@eoyilmaz
[#16] Added some debug prints for GitHub tests (7).
4f21015
@eoyilmaz
[#16] Added some debug prints for GitHub tests (8).
e8ee109
@eoyilmaz
[#16] Fixing check_call() and check_call_str() in `DisplayCAL.dev…
386e24c 
….mocks` for a possible bug.
@eoyilmaz
[#16] Fixed tests.test_edid.test_get_edid_1() to run properly with …
a36be9b 
…the mocked `xrandr` output.
@eoyilmaz
[#16] Re-enabled building wxPython for tests.
fbb0f34
@eoyilmaz
[#16] Removed temporary debug messages.
59106f2
@eoyilmaz
[#16] Fixed `DisplayCAL.RealDisplaySizeMM.Display.from_dispwin_data()…
70e4474 
…` and `DisplayCAL.RealDisplaySizeMM._enumerate_displays()` for ArgyllCMS<3.3.0 style output.
p5k369
p5k369 previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@p5k369 p5k369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and runs on linux.

@eoyilmaz
Copy link
Owner Author

eoyilmaz commented Oct 22, 2024 •
edited
Loading

Tested and runs on linux.

Seems to be running fine under Windows too, and although you reported it is running fine under Linux, I'll be testing it in Fedora too, just for fun 😄

@eoyilmaz
Copy link
Owner Author

The only issue I seem to find is that the wheel name is DisplayCAL-3.9.14-py3-none-any.whl instead of DisplayCAL-3.9.14-py3-cp311-cp311-any.whl I wonder if this is intentional as we don't have a C-Extension anymore?

@eoyilmaz eoyilmaz self-assigned this Oct 22, 2024
@p5k369
Copy link
Collaborator

p5k369 commented Oct 22, 2024

That just indicates that the wheels isn't cpython specific anymore.

@eoyilmaz eoyilmaz merged commit af9d0eb into develop Oct 23, 2024
13 checks passed
@eoyilmaz eoyilmaz deleted the 16-get-rid-of-realdisplaysizemm-c-extension branch October 23, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p5k369 p5k369 p5k369 left review comments

Assignees

@eoyilmaz eoyilmaz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of RealDisplaySizeMM C-Extension
2 participants
@eoyilmaz @p5k369