Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy.code.check --since can fail #630

Open
phlax opened this issue Jan 19, 2023 · 0 comments
Open

envoy.code.check --since can fail #630

phlax opened this issue Jan 19, 2023 · 0 comments

Comments

@phlax
Copy link
Member

phlax commented Jan 19, 2023

Not sure why it does/not work locally, but testing ...

$ bazel run //tools/code:check -- -s main

  File "/home/worker/.cache/bazel/_bazel_worker/f704bab1b165ed1368cb88f9f49e7532/execroot/envoy/bazel-out/k8-fastbuild/bin/tools/code/check.runfiles/base_pip3_aio_core/site-packages/aio/core/functional/decorators.py", line 128, in load_cooperatively
    return await self.load(instance)
  File "/home/worker/.cache/bazel/_bazel_worker/f704bab1b165ed1368cb88f9f49e7532/execroot/envoy/bazel-out/k8-fastbuild/bin/tools/code/check.runfiles/base_pip3_aio_core/site-packages/aio/core/dev/debug.py", line 89, in fun_async
    await self.__wrapped__(*args, **kwargs))
  File "/home/worker/.cache/bazel/_bazel_worker/f704bab1b165ed1368cb88f9f49e7532/execroot/envoy/bazel-out/k8-fastbuild/bin/tools/code/check.runfiles/base_pip3_aio_core/site-packages/aio/core/functional/decorators.py", line 120, in load
    return self.set_prop_cache(instance, await self.fun(instance))
  File "/home/worker/.cache/bazel/_bazel_worker/f704bab1b165ed1368cb88f9f49e7532/execroot/envoy/bazel-out/k8-fastbuild/bin/tools/code/check.runfiles/base_pip3_aio_core/site-packages/aio/core/directory/abstract/directory.py", line 371, in files
    (await self.get_files()
TypeError: unsupported operand type(s) for &: 'set' and 'dict'

whereas bazel run //tools/code:check -- -s upstream/main works - i guess because these produce different filesets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant