Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify GetResult() method in extractor in PME filter #37362

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Fix const issue

2f9c389
Select commit
Loading
Failed to load commit list.
Open

Modify GetResult() method in extractor in PME filter #37362

Fix const issue
2f9c389
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/CC succeeded Nov 26, 2024 in 2m 38s

Mobile/CC (success)

Check has finished

Details

Check run finished (success ✔️)

The check run can be viewed here:

Mobile/CC (pr/37362/main@2f9c389)

Check started by

Request (pr/37362/main@2f9c389)

dchakarwarti @dchakarwarti 2f9c389 #37362 merge main@4aa1d1b

Modify GetResult() method in extractor in PME filter

Commit Message: Modify GetResult() method in extractor in PME filter

Additional Description:
Clear request metadata and response metadata once the result is fetched. This ensures no messages are carried over in a streaming request. Please note that we call GetResult() once to fetch the metadata.

Risk Level: Low

Testing: Covered by unit tests

Docs Changes: Nil

Release Notes: Nil

Platform Specific Features: Nil

Environment

Request variables

Key Value
ref 25ae446
sha 2f9c389
pr 37362
base-sha 4aa1d1b
actor dchakarwarti @dchakarwarti
message Modify GetResult() method in extractor in PME filter...
started 1732612839.546068
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:f94a38f62220a2b017878b790b6ea98a0f6c5f9c
mobile envoyproxy/envoy-build-ubuntu:mobile-f94a38f62220a2b017878b790b6ea98a0f6c5f9c
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true