Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: metadata behavior when disallowed #37322

Open
paul-r-gall opened this issue Nov 22, 2024 · 1 comment
Open

http2: metadata behavior when disallowed #37322

paul-r-gall opened this issue Nov 22, 2024 · 1 comment
Labels
area/metadata enhancement Feature requests. Not bugs or questions.

Comments

@paul-r-gall
Copy link
Contributor

Title: How to handle HTTP2 metadata when allow_metadata is false.

Description:
See #37152 (comment). When allow_metadata is false, new default behavior when Envoy attempts to send Metadata is to ENVOY_BUG and drop the metadata on the ground. It's debatable as to whether that's the correct behavior or not. We could potentially expand allow_metadata from a Bool to a more general purpose enum that looks like (pardon my syntax)

enum H2MetadataBehavior {
  DROP
  DROP_AND_ENVOY_BUG
  ALLOW
  ASSERT_FAIL
}

etc.

@paul-r-gall paul-r-gall added bug triage Issue requires triage labels Nov 22, 2024
@RyanTheOptimist RyanTheOptimist added enhancement Feature requests. Not bugs or questions. area/metadata and removed bug triage Issue requires triage labels Nov 26, 2024
@RyanTheOptimist
Copy link
Contributor

@birenroy @alyssawilk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/metadata enhancement Feature requests. Not bugs or questions.
Projects
None yet
Development

No branches or pull requests

2 participants