Add formFactor filter for operators graphql query #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The vehicleTypes property of FeedProvider is intended as a way to hard code static vehicle type data from feedproviders.yml if the upstream data source does not provide it. It is not populated with actual data from upstream data sources. |
|
Oh, I see. Will explore, if |
|
Yeah, you could of course iterate over all systems and fetch their vehicle_types.json from the cache, and aggregate the data from there, but it is a bit brute. I do have some ideas on how this should be solved, but I need to flesh it out a bit with some drawing. I think it involves adding the concept of an Operator entity. Are you available next week for a call and we can discuss it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
formFactoras optional filter to the graphqloperatorsquery.An operator matches a given
formFactor, if anyvehicle_typeit rents has of the requestedformFactors.Note: this filter evaluates
vehicle_types, not currently available vehicle_types.This PR fixes #215.