-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the J command better #231
Comments
tbleher
pushed a commit
to tbleher/tip-toi-reveng
that referenced
this issue
Dec 1, 2020
The J() command is executed after all other commands in the line have executed. Simulate this correctly.
tbleher
pushed a commit
to tbleher/tip-toi-reveng
that referenced
this issue
Dec 1, 2020
The J() command is executed after all other commands in the line have executed. The 2s pause if no P() follows J() (as documented in entropia#179 (comment)) is not implemented yet.
tbleher
pushed a commit
to tbleher/tip-toi-reveng
that referenced
this issue
Dec 5, 2020
As discussed in entropia#231 and entropia#238, TipToi pens handle a jump after all other actions (even if they are earlier in the list). If there are multiple jumps, only the last has an effect. This lint check verifies that a GME only contains one jump, and that the jump is the last action. This check is true for all GMEs published by Ravensburger.
tbleher
pushed a commit
to tbleher/tip-toi-reveng
that referenced
this issue
Dec 5, 2020
As discussed in entropia#231 and entropia#238, TipToi pens handle a jump after all other actions (even if they are earlier in the list). If there are multiple jumps, only the last has an effect. This lint check verifies that a GME only contains one jump, and that the jump is the last action. This check is true for all GMEs published by Ravensburger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With a6f8581 the documentation finally explains the rules around
J
(I hope I got them right), thanks to @SciLor to summarize them in #179 (comment).But
tttool
should be smarter about them, andtttool play
(reported in Play - Implement J(x) P(y) - Protected Jump #179)tttool assemble
tttool lint
, check existing GME files for deviations from this rule (might be worth checking them out to see how they behave)The text was updated successfully, but these errors were encountered: