Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some passes to Mini passes #11191

Merged
merged 90 commits into from
Oct 15, 2024
Merged

Migrate some passes to Mini passes #11191

merged 90 commits into from
Oct 15, 2024

Commits on Sep 26, 2024

  1. Implement skeleton of mini pass framework

    @Akirathan
    Akirathan committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    c9ef2c3 View commit details
    Browse the repository at this point in the history

  2. Rename MiniPassManager to MiniPassChainer

    @Akirathan
    Akirathan committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    43eafae View commit details
    Browse the repository at this point in the history

  3. Implement default IR.withNewChildren

    @Akirathan
    Akirathan committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    4a0fd85 View commit details
    Browse the repository at this point in the history

  4. Add MiniPassTester and MiniPassTraverser

    @Akirathan
    Akirathan committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    1bbf991 View commit details
    Browse the repository at this point in the history

  5. Add tests for OperatorToFunction mini pass

    @Akirathan
    Akirathan committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    70f0a1a View commit details
    Browse the repository at this point in the history

  6. Add necessary withNewChildren implementations

    @Akirathan
    Akirathan committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    808dbd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Add necessary withNewChildren implementations

    @Akirathan
    Akirathan committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1abc70d View commit details
    Browse the repository at this point in the history

  2. MiniIRPass has metadata type argument

    @Akirathan
    Akirathan committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    cdf1d87 View commit details
    Browse the repository at this point in the history

  3. Add mini pass version of LambdaShorthandToLambda

    @Akirathan
    Akirathan committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d7b6016 View commit details
    Browse the repository at this point in the history

  4. Add tests of mini pass version of LambdaShorthandToLambda

    @Akirathan
    Akirathan committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    1bd2b40 View commit details
    Browse the repository at this point in the history

  5. Implement Prefix.withNewChildren

    @Akirathan
    Akirathan committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    61fed92 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Add IRTest to test children and withNewChildren API

    @Akirathan
    Akirathan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    40252a2 View commit details
    Browse the repository at this point in the history

  2. Update default IR.withNewChildren

    @Akirathan
    Akirathan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    76dbc23 View commit details
    Browse the repository at this point in the history

  3. Copy of children of DefinitionArgument.Specified is handled specifica… 

    …lly.
    @Akirathan
    Akirathan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    4a66460 View commit details
    Browse the repository at this point in the history

  4. Add necessary withNewChildren implementations

    @Akirathan
    Akirathan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    be2724d View commit details
    Browse the repository at this point in the history

  5. LambdaToShorthandMini ignores blank fn

    @Akirathan
    Akirathan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    fd3a727 View commit details
    Browse the repository at this point in the history

  6. Tests that have different internal naming are handled in different te… 

    …st cases.
    @Akirathan
    Akirathan committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    8a5c435 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. DefinitionArgument.Specified implements withNewChildren

    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    995dea5 View commit details
    Browse the repository at this point in the history

  2. Change prepare API 

    - It returns reference of MiniIRPass
    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    985b8c2 View commit details
    Browse the repository at this point in the history

  3. MiniIRPass is not parametrized based on metadata type

    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    28edccb View commit details
    Browse the repository at this point in the history

  4. Dummy implementation of minipass chaining

    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6121750 View commit details
    Browse the repository at this point in the history

  5. Add test for BinaryOperator.newChildren

    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    54e5bd0 View commit details
    Browse the repository at this point in the history

  6. IR.withNewChildren must be called with the same length as children

    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    6b4c6b3 View commit details
    Browse the repository at this point in the history

  7. MiniIRPass.prepare has parent parameter

    @Akirathan
    Akirathan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    01561a1 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Remove parent parameter from MiniIRPass.prepare

    @Akirathan
    Akirathan committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    dd42554 View commit details
    Browse the repository at this point in the history

  2. Remove MiniIRPass.runsAfter - it will not be necessary for this PR

    @Akirathan
    Akirathan committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f85f017 View commit details
    Browse the repository at this point in the history

  3. Add docs to MiniIRPass

    @Akirathan
    Akirathan committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    a4aaf8e View commit details
    Browse the repository at this point in the history

  4. Add skeleton of TailCallMini pass

    @Akirathan
    Akirathan committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    836c4c2 View commit details
    Browse the repository at this point in the history

  5. runtime-compiler depends on org.graalvm.sdk:collections

    @Akirathan
    Akirathan committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    079543a View commit details
    Browse the repository at this point in the history

  6. Implement withNewChildren on Expression via mapExpressions

    @Akirathan
    Akirathan committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    5d19be4 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Fix MatchError in TailCallMini

    @Akirathan
    Akirathan committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    a369ed8 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Revert "Implement withNewChildren on Expression via mapExpressions" 

    This reverts commit 5d19be4.
    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    487003f View commit details
    Browse the repository at this point in the history

  2. Revert "runtime-compiler depends on org.graalvm.sdk:collections" 

    This reverts commit 079543a.
    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    b2f7053 View commit details
    Browse the repository at this point in the history

  3. Replace org.graalvm.collections.EconomicSet with java.util.IdentityHa… 

    …shMap
    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    edec03b View commit details
    Browse the repository at this point in the history

  4. Revert tests that depend on InlineContext config

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    67ff454 View commit details
    Browse the repository at this point in the history

  5. Add more tests that test consistency with old pass version

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    547e9e6 View commit details
    Browse the repository at this point in the history

  6. Add logging to MiniPassTraverser

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    925a2de View commit details
    Browse the repository at this point in the history

  7. Implement more withNewChildren methods

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    dc6e7f3 View commit details
    Browse the repository at this point in the history

  8. Add another tail call mini pass test

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    c56c2be View commit details
    Browse the repository at this point in the history

  9. TailCallMini respect initial isInTailPosition flag

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ea1462a View commit details
    Browse the repository at this point in the history

  10. Implement TailCallMini.toString

    @Akirathan
    Akirathan committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    18f4cea View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Using IR.mapExpressions in MiniPassTraverser

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e2fc538 View commit details
    Browse the repository at this point in the history

  2. Detect and use MiniPassFactory in PassFactory

    @JaroslavTulach
    JaroslavTulach committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    a58ecc8 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Move OperatorToFunction mega pass to test

    @Akirathan
    Akirathan committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1aaa589 View commit details
    Browse the repository at this point in the history

  2. Move LambdaShorthandToLambda mega pass to test

    @Akirathan
    Akirathan committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8604acb View commit details
    Browse the repository at this point in the history

  3. Use pattern match instead of isInstanceOf check in PassManager

    @Akirathan
    Akirathan committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0ddb96b View commit details
    Browse the repository at this point in the history

  4. Move TailCall mega pass to test

    @Akirathan
    Akirathan committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a85679d View commit details
    Browse the repository at this point in the history

  5. Implement MiniPass trait for testing mini and mega passes

    @Akirathan
    Akirathan committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    80c4545 View commit details
    Browse the repository at this point in the history

  6. TailCallMegaPass uses metadata from TailCall, not this

    @Akirathan
    Akirathan committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9a5dfea View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Change API of MiniIRPass to accept only Expression

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d5c6983 View commit details
    Browse the repository at this point in the history

  2. OperatorToFunctionMini checks post condition

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    89cde89 View commit details
    Browse the repository at this point in the history

  3. Add failing test to OperatorToFunctionTest

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7c9f370 View commit details
    Browse the repository at this point in the history

  4. Implement IRDumper.dumpWithSvg

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    92ae4fe View commit details
    Browse the repository at this point in the history

  5. Ensure MiniPassTraverser returns transformed Module

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    65560c4 View commit details
    Browse the repository at this point in the history

  6. IRDumper handles SugaredType

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    dfc54db View commit details
    Browse the repository at this point in the history

  7. MiniPassTraverser logs IRs with hash code.

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8771d58 View commit details
    Browse the repository at this point in the history

  8. Refactor TailCallMini to the new API

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bdff605 View commit details
    Browse the repository at this point in the history

  9. typo

    @Akirathan
    Akirathan committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ce56abb View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Must preprocess the module even for miniPass

    @JaroslavTulach
    JaroslavTulach committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d42d3e9 View commit details
    Browse the repository at this point in the history

  2. Using analyseModuleBinding from TailCallMegaPass

    @JaroslavTulach
    JaroslavTulach committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ba7ab9d View commit details
    Browse the repository at this point in the history

  3. Allow for comparing mega and mini IR trees

    @JaroslavTulach
    JaroslavTulach committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    90139e7 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2024

  1. Merging with develop. 47 failing tests. Mostly because of advanturous… 

    … usage of unfinished TailCall mini pass. With the original TailCall pass the failures get to acceptable level.
    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8558d5b View commit details
    Browse the repository at this point in the history

  2. Making the TailCall pass closer to original mega pass code

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    05fd38a View commit details
    Browse the repository at this point in the history

  3. Properly annotate withClue sections

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    367fc9a View commit details
    Browse the repository at this point in the history

  4. Associate TailCall pass metadata

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    36ebf2b View commit details
    Browse the repository at this point in the history

  5. Rewrite using tailCandidates

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    0a02563 View commit details
    Browse the repository at this point in the history

  6. Removal of notTailMeta

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    83f4a57 View commit details
    Browse the repository at this point in the history

  7. Execute megaPass.runExpression at the end of the test

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    69b3274 View commit details
    Browse the repository at this point in the history

  8. One TailCallTest failure down to six

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    dea6dd6 View commit details
    Browse the repository at this point in the history

  9. Down to five failing tests in TailCallTest

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    6c2b51d View commit details
    Browse the repository at this point in the history

  10. Down to three failures

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    f27ce6f View commit details
    Browse the repository at this point in the history

  11. Reordering the test and down to two failures

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    f4077de View commit details
    Browse the repository at this point in the history

  12. Making all TailCallTest pass on mega as well as mini pass

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    1b021c2 View commit details
    Browse the repository at this point in the history

  13. No need for TailCallMini

    @JaroslavTulach
    JaroslavTulach committed Oct 12, 2024
    Configuration menu
    Copy the full SHA
    8ce42e0 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Cleaning dead code up

    @JaroslavTulach
    JaroslavTulach committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    64b013f View commit details
    Browse the repository at this point in the history

  2. SectionsToBinOp is mini IR pass

    @JaroslavTulach
    JaroslavTulach committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    f54ba6d View commit details
    Browse the repository at this point in the history

  3. Introducing MiniIRPass.combine

    @JaroslavTulach
    JaroslavTulach committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    40ef345 View commit details
    Browse the repository at this point in the history

  4. Hiding traversal behind MiniIRPass.compile

    @JaroslavTulach
    JaroslavTulach committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    8124e1e View commit details
    Browse the repository at this point in the history

  5. Not including IRDumper changes in this PR

    @JaroslavTulach
    JaroslavTulach committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    668fdfd View commit details
    Browse the repository at this point in the history

  6. No need for MetadataStorage.size

    @JaroslavTulach
    JaroslavTulach committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    2af068f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Properly clone ChainedMiniPass when first or second delegates changes

    @JaroslavTulach
    JaroslavTulach committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    95b1756 View commit details
    Browse the repository at this point in the history

  2. Removing duplicated test - mini pass testing is already inside of ass… 

    …ertInlineCompilation
    @JaroslavTulach
    JaroslavTulach committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c84e881 View commit details
    Browse the repository at this point in the history

  3. Rewriting MiniIRPass processing to queue - much easier for profiling … 

    …each mini pass
    @JaroslavTulach
    JaroslavTulach committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    0964711 View commit details
    Browse the repository at this point in the history

  4. MiniIRPass.prepare(parent, child)

    @JaroslavTulach
    JaroslavTulach committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ffd27df View commit details
    Browse the repository at this point in the history

  5. Keep all IRs in local variables for easier debugging

    @JaroslavTulach
    JaroslavTulach committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    924e404 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Combining subsequent mini passes

    @JaroslavTulach
    JaroslavTulach committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2736a76 View commit details
    Browse the repository at this point in the history

  2. Both MiniPassFactory and IRPass are on par by extending IRProcessingPass

    @JaroslavTulach
    JaroslavTulach committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    762045a View commit details
    Browse the repository at this point in the history

  3. Only update IR metadata in transform methods

    @JaroslavTulach
    JaroslavTulach committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ef3450c View commit details
    Browse the repository at this point in the history

  4. Removing dead code

    @JaroslavTulach
    JaroslavTulach committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    248c0f4 View commit details
    Browse the repository at this point in the history

  5. TailCall rewritten to Java

    @JaroslavTulach
    JaroslavTulach committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    befef0c View commit details
    Browse the repository at this point in the history