Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "crop_type" parameter for user friendly round image rendering #58

Open
mdtanrikulu opened this issue Dec 9, 2021 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@mdtanrikulu
Copy link
Contributor

To support round image components adjust logo and text overlay if crop_type=round parameter provided.

@mdtanrikulu mdtanrikulu added the enhancement New feature or request label Dec 9, 2021
@mcmns
Copy link

mcmns commented Dec 9, 2021

In case it’s helpful, here’s an example of how another NFT project handles providing alternative images for avatars and banners. (They don’t have the challenge of designing text over images, but it’s interesting to see how they’ve chosen to reposition, resize, and omit certain elements depending on the ratio/anticipated crop.)

Importantly, the “avatar” image — equivalent to the proposed “crop_type=round” parameter — doesn’t crop the image to be a circle, it repositions the foreground elements to look good when cropped to a circle by third parties.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants