Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With Vic's Point Blank Mod installed, the camera does not rotate left or right when flying with an elytra. #160

Open
byxea opened this issue Jul 20, 2024 · 6 comments

Comments

@byxea
Copy link

byxea commented Jul 20, 2024

Describe the issue
When Vic's Point Blank mod is installed alongside Do a barrel roll, the camera does not rotate left or right when flying with an elytra.

Crash report/logs (if applicable)
https://mclo.gs/ZtUDCiH

Screenshots
image
^ Flying upside down, camera doesn't rotate

image
^ Flying sideways, again camera doesn't rotate

image
^ Intended camera rotation when flying upside down with Vic's Point Blank not installed.

image
^ Intended camera rotation when flying sideways

MC version: 1.21

Mods

  • Do a Barrel Roll 3.6.1+1.21
  • Point Blank 1.6.1
  • CICADA 0.8.3+1.21-and-above
  • GeckoLib 4 4.5.7
  • Fabric API 0.100.7+1.21
  • Sodium 0.5.11+mc1.21
@enjarai
Copy link
Owner

enjarai commented Jul 20, 2024

Point Blank is probably redirecting a specific method call that DABR modifies in its own way to make rolling work. I cant be sure of this though, since Point Blank seems to be closed source. This means a fix will probably have to come from their side. :/

@hologarden
Copy link

also having this problem with vic's point blank installed, same config as @byxea

@enjarai
Copy link
Owner

enjarai commented Jul 22, 2024

I've looked into the issue, and its most likely a conflict with DABR's mixin here: https://github.com/enjarai/do-a-barrel-roll/blob/arch/1.21/common/src/main/java/nl/enjarai/doabarrelroll/mixin/client/roll/CameraMixin.java

The main issue stands though. Because Point Blank is closed source, I have no idea what they're doing to break this. For a fix to happen, the author of VPB will have to either implement a fix themselves, or contact me with more details on the exact nature of their mixin. I'd be happy to implement a compatibility patch if I know what the underlying cause of the issue is.

@Twister1M
Copy link

Twister1M commented Aug 11, 2024

I'm having a similar issue in the modpack Prominence II RPG, but I do not have the above mod as part of it:
https://www.curseforge.com/minecraft/modpacks/prominence-2-rpg

This makes me think it isn't mod specific but some other issue multiple different mods could have.

For me, the vertical camera rotation works but not the rolling camera (I can do loops with the camera, but not rolls). What's interesting is that it worked the first time I used the elytra, but after logging off for the night, when I came back I had the same issue as above. To note, only I have the issue, so there seems to be some inconsistencies about the problem in multiplayer.

@RichBrinky
Copy link

Just encountered the same problem as @Twister1M, worked like a charm on a server hosted by a friend for a while, then during this day it stopped working, Might be hitting a specific keybind in the modpack or going to a singleplayer world halfway thorugh the day maybe?

@JustAFoosh
Copy link

JustAFoosh commented Dec 13, 2024

Same issue as @Twister1M and @RichBrinky. Was working fine, no issues, up until the server crashed. Nothing was corrupted, no issues with anyone else, but my camera no longer rolls left and right. I can do full loops up and down, but the camera will not tilt whatsoever. I did not join a different world, did not hit a new keybind, so Idk what's causing it.

Edit: It does not work in single player either, and in my config panel, Inverting Pitch does not work. Switching Roll and Yaw has no effect, though mainly because the mouse is already controlling exclusively yaw. Setting the Keybinds to roll left or right does nothing. Yaw Left, and Yaw Right Keybinds do nothing. Pitch Up and Pitch down Keybinds do nothing. I genuinely have no clue what's happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants