We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows compatibility
introduces a couple scripts which run fine in CI (ubuntu-latest) and locally (macOS), but may not on Windows
endo/packages/ses/package.json
Line 73 in 13aa1af
runs on my Win11 machine #2334 (comment) but may not for others
Line 85 in 13aa1af
doesn't run on Windows #2334 (comment)
it could be a good idea to support Windows contributors running these locally including those setup to run React Native on Windows
1 build:hermes util.parseArgs #2334 (comment)
build:hermes
2 test:hermes unsure how to run this on Windows, @boneskull may have an idea
test:hermes
consider running windows-latest in CI (Windows Server 2022)
The text was updated successfully, but these errors were encountered:
@leotm here's an example of including windows in a build matrix:
jobs: build: name: Node.js v${{ matrix.node_version }} / ${{ matrix.os }} runs-on: ubuntu-latest strategy: matrix: node_version: [18, 20] os: [ubuntu-latest, windows-latest] steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 - name: Use Node.js ${{ matrix.node_version }} uses: actions/setup-node@b39b52d1213e96004bfcb1c61a8a6fa8ab84f3e8 # v4.0.1 with: node-version: ${{ matrix.node_version }}
The Windows job(s) will be running under pwsh, which will quickly surface portability issues.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
What is the Problem Being Solved?
Windows compatibility
introduces a couple scripts which run fine in CI (ubuntu-latest) and locally (macOS), but may not on Windows
endo/packages/ses/package.json
Line 73 in 13aa1af
runs on my Win11 machine #2334 (comment) but may not for others
endo/packages/ses/package.json
Line 85 in 13aa1af
doesn't run on Windows #2334 (comment)
it could be a good idea to support Windows contributors running these locally
including those setup to run React Native on Windows
Description of the Design
1
build:hermes
util.parseArgs #2334 (comment)2
test:hermes
unsure how to run this on Windows, @boneskull may have an ideaSecurity Considerations
Scaling Considerations
Test Plan
consider running windows-latest in CI (Windows Server 2022)
Compatibility Considerations
Upgrade Considerations
The text was updated successfully, but these errors were encountered: