Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix curl error #7

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Fix curl error #7

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
7ad27f3
init commit.
Mar 10, 2021
75086e4
Merge branch 'master' into fix_curl_error
Mar 10, 2021
392ff94
add agent upload/download functions.
Mar 11, 2021
c8a2043
fix runner.
Mar 11, 2021
f4f3269
attempted small fixes.
akama Mar 12, 2021
2d9f74c
fix annoying bug re \n getting inserted.
akama Mar 12, 2021
c6ff4f6
this should work?
akama Mar 26, 2021
69cf7c0
update mc settings.
akama Mar 26, 2021
2bdb859
Wait longer and print more detailed error messages
hcarty Apr 19, 2021
063c418
Merge remote-tracking branch 'origin/master' into fix_curl_error
hcarty Apr 19, 2021
2249c64
Merge remote-tracking branch 'origin/master' into fix_curl_error
hcarty Apr 27, 2021
e8ad6eb
Fix some warnings, replace ocaml-monadic with let-operators
hcarty Apr 28, 2021
948ecc4
Catch cohttp client exceptions, add lwt_ppx
hcarty Apr 28, 2021
38d7238
Get rid of some more ocaml-monadic
hcarty Apr 28, 2021
f193110
Get rid of just a bit more ocaml-monadic
hcarty Apr 28, 2021
2cb8dfb
Try with an older Ubuntu to get an older glibc
hcarty Apr 28, 2021
4d3de18
Try with a slightly newer Ubuntu which has bubblewrap packaged for it
hcarty Apr 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions engine/provider_aws.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,13 +229,14 @@ module Aws : Provider_template.Provider = struct
process_response resp
in
let%lwt _resp, body =
match%lwt repeat_until_ok send_command 10 with
match%lwt repeat_until_ok send_command 60 with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good!

| Ok (r, b) ->
Lwt.return (r, b)
| Error _ ->
failwith
| Error (`Msg message, note) ->
Lwt.fail_with (Fmt.str
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we leave this as failwith (or even Fmt.failwith)? The lwt docs mention that it might be better to prefer failwith over Lwt.fail_with if we don't attempt to store or catch the rejected promise further up the chain since failwith will result in the runtime recording the backtrace.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair question. In theory using the Lwt ppx should give decent backtraces. But that's not happening here so something is missing somewhere.

"Can't talk to an agent, this probably means the agent failed to \
install."
install. Error: %s - %s"
message note)
in
(*TODO cohttp_retry*)
let poll_agent () =
Expand Down