Fix curl error

[akringwood]

No description provided.

[jeska]

@UnrealAkama Can you merge this in? 👀

[akringwood]

Sorry about this, life has been a bit crazy, I fixed what I think is the last bug in this and have updated test release. I'm going to give it a try this weekend and make sure everything works but you should be able to use the binaries in that release to replace the current ones and test it out.

[jeska]

@akringwood thanks! we set it up yesterday to initially great success, but now we're getting this error pretty frequently:

mc: internal error, uncaught exception:
    (Failure
      "Can't talk to an agent, this probably means the agent failed to install.")
    Raised at Engine__Runner.main.(fun) in file "engine/runner.ml", line 467, characters 6-13
    Called from Lwt.Sequential_composition.try_bind.create_result_promise_and_callback_if_deferred.callback in file "src/core/lwt.ml", line 2160, characters 23-28
    Re-raised at Lwt.Miscellaneous.poll in file "src/core/lwt.ml", line 3072, characters 20-29
    Called from Lwt_main.run.run_loop in file "src/unix/lwt_main.ml", line 31, characters 10-20
    Called from Lwt_main.run in file "src/unix/lwt_main.ml", line 118, characters 8-13
    Re-raised at Lwt_main.run in file "src/unix/lwt_main.ml", line 124, characters 4-13
    Called from Cmdliner_term.app.(fun) in file "cmdliner_term.ml", line 25, characters 19-24
    Called from Cmdliner.Term.run in file "cmdliner.ml", line 117, characters 32-39
Something has gone wrong for run f130c267-8ea7-4a63-a82a-e1b3a660a8cf, we received in exception:
 (Failure
  "Can't talk to an agent, this probably means the agent failed to install.") 

Any ideas?

[akringwood]

Hmmm, that's odd, it seems like the agent isn't starting reliably. Normally that's due to me forgetting to set the bins acl to public so that the agents can access it cause they have to bootstrap themselves. We are using this as well and aren't seeing it so let me do some testing and figure out what I can see. You can also log onto the makecloud nodes themselves by adjusting the key in the mc_settings file and then sshing into the box once you've left it alive with --dont-delete. Trying to run the agent, it should be in / might also illuminate somethings.

[donaherc]

I think this is good!

[donaherc]

LGTM when I scanned it, we shipped this out to before right? or are we not using this?

[hcarty]

Yeah, we've been using a build from this branch, built before this timing change

[anuragsoni]

Should we leave this as failwith (or even Fmt.failwith)? The lwt docs mention that it might be better to prefer failwith over Lwt.fail_with if we don't attempt to store or catch the rejected promise further up the chain since failwith will result in the runtime recording the backtrace.

[hcarty]

Fair question. In theory using the Lwt ppx should give decent backtraces. But that's not happening here so something is missing somewhere.