-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Support missing events #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Thanks for the walk through and good tests!
Once we merge this in, we will hold cutting a release until ipv6 cidmatch support is added (shortly after). |
🟢 Independent package testing works as expected, LGTM 👍 Details
Negation Test Code: import eql
query = '''
sequence with maxspan=2m [any where process: "cmd.exe"] [any where process: "Fake.exe"]
'''
with eql.parser.elasticsearch_syntax, eql.parser.allow_negation:
parsed = eql.parse_query(query, implied_any=True, implied_base=True)
data_to_filter = [{"process": "cmd.exe", "@timestamp": "2023-05-22T20:03:56.020Z"}, {"process": "bash.exe", "@timestamp": "2023-05-22T20:03:57.020Z"}]
filter_engine = eql.get_engine(parsed)
print(f"Original Query: {query}")
print(f"Output: {filter_engine(data_to_filter)}")
print("-" * 50)
query = '''
sequence with maxspan=2m [any where process: "cmd.exe"] ![any where process: "Fake.exe"]
'''
with eql.parser.elasticsearch_syntax, eql.parser.allow_negation:
parsed = eql.parse_query(query, implied_any=True, implied_base=True)
filter_engine = eql.get_engine(parsed)
print(f"Negated Query: {query}")
print(f"Output: {filter_engine(data_to_filter)}") |
CHANGELOG.md
Outdated
@@ -1,6 +1,14 @@ | |||
# Event Query Language - Changelog | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
|
|||
# Version 0.9.19 | |||
|
|||
_Released 2023-10-10_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will bump before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No other changes that I could find ✅ |
Issues
Resolves #69
Details
Adds support for the negative feature used within elasticsearch sequences.
Testing
Unit tests should pass.
Additional Information
Related to elastic/detection-rules#3136