Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Handle deleting post during generation workflow #640

Open
2 tasks done
JoelWiebe opened this issue Dec 3, 2024 · 2 comments · May be fixed by #643
Open
2 tasks done

BUG: Handle deleting post during generation workflow #640

JoelWiebe opened this issue Dec 3, 2024 · 2 comments · May be fixed by #643
Assignees
@markiianbabiak
Labels
bug Something isn't working

Comments

@JoelWiebe
Copy link
Contributor

JoelWiebe commented Dec 3, 2024 •
edited by markiianbabiak
Loading

Bug

Overview
If a student deletes a post during a generation task after having created one, the progress bar does not decrease by one and the task can be completed with one post too few.

To Reproduce
Steps to reproduce:

  1. Create a generation task with two or more posts to generate
  2. Create a post then delete it
  3. Create another post
  4. You will see that the progress bar suggests that two posts are created. If you create all posts, the task will be marked as completed when total required - 1 are created.

Proposed tasks to fix

  • Deleting a post should reduce the progress bar for both the teacher monitor and the student workspace progress bar
  • Ensure task is only marked as completed when the total number of generated posts are created (ignoring the deleted posts) -- this behaviour may already exist once the prior item is fixed

Screenshots
If applicable, add screenshots to help explain your problem.
@JoelWiebe JoelWiebe added the bug Something isn't working label Dec 3, 2024
@markiianbabiak
Copy link
Contributor

@JoelWiebe When the post is removed from some other view(eg. canvas), does the progress have to be updated too?

@JoelWiebe
Copy link
Contributor Author

@JoelWiebe When the post is removed from some other view(eg. canvas), does the progress have to be updated too?

@markiianbabiak Thanks for working on this. Sorry, I should have specified, this would only apply to deleting a post from the workspace during a generation task.

I.e., If someone is completing a generation task that requires creating two posts, if they create a post in the workspace for that task then progress should go up to 50%, when they delete the post from within the workspace for that task, progress would go down to 0%, then the user should still need to create two more posts to complete the task. This should not be affected by what happens in other views outside the workspace.

@markiianbabiak markiianbabiak linked a pull request Dec 28, 2024 that will close this issue
640 bug handle deleting post during generation workflow #643
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markiianbabiak markiianbabiak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

640 bug handle deleting post during generation workflow encorelab/ck-board
2 participants
@JoelWiebe @markiianbabiak