fix: pass any attribute value type to markup

[callinmullaney]

Summary

• Related PR for npm package - fix: convert value to string before inspecting what it contains emulsify-twig-extensions#6
• add_attributes doesn't handle integers emulsify-twig-extensions#4

This PR fixes/implements the following bugs/features

• Allow for non-string values to be passed to the add_attributes function within a Drupal twig template

Explain the motivation for making this change. What existing problem does the pull request solve?

• It's sometimes necessary to pass an integer as a value for an attribute. In particular colspan for <td> elements. Currently, this value must be converted to a string BEFORE being passed to add_attributes()

Documentation Update (required)

• none

How to review this PR

• Edit any component and assign some test attrbitues to a variable: Note - we are passing an integer value directly to colspan and a boolean/string/integer multivalue via an array to data-test-attribute - The result of the boolean value should be 1

{% set test_attributes = test_attributes|default({
  'colspan': 3,
  'data-test-attribute': [TRUE, 'string', 123],
}) %}

• Call the add_attributes function on an element within a Drupal twig template

<div {{ add_attributes(test_attributes) }}></div>

• Inspect the markup and verify the above attributes are being properly rendered

Closing issues
emulsify-ds/emulsify-twig-extensions#4

[ccjjmartin]

Got a question for you.

[ccjjmartin]

@callinmullaney I am thinking this is a little too open, it seems like your use case (original question) is to support integers. Should we not have another case to handle integers (convert them to a string)?

Currently this is what I am seeing we are processing:

1. Arrays (flat) - technically nested arrays would just not work
2. (object) Attribute
3. Strings
4. Default - Do nothing

I think this would read easier if we were using a switch statement here.

[callinmullaney]

@ccjjmartin I updated this PR to use a switch statement like you suggested. The original scope of this issue was to handle passing integers type values but with the changes I made we can also handle boolean.

That being said, while nested arrays and objects would also be a nice thing to process if passed to add_atributes() I think it's a bit out of scope for the original issue. The switch statement framework established here would be a good jumping off point for another branch to add support.

Can you take a quick look at this and confirm the testing criteria above?

[ccjjmartin]

@callinmullaney Code looks good, functional works with test described 👍

[github-actions]

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀