Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design tokens for Tooltip component #159

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Design tokens for Tooltip component #159

merged 7 commits into from
Nov 21, 2024

Conversation

mariannuar
Copy link
Collaborator

@mariannuar mariannuar commented Sep 17, 2024 •
edited
Loading

Summary

Design tokens for the new Tooltip component

How to review this pull request

  • To review, confirm that Tooltip component exists and it has design tokens in Emulsify UI Kit

@mariannuar mariannuar changed the title Tooltip Design tokens for Tooltip component Sep 17, 2024
@mariannuar mariannuar self-assigned this Sep 17, 2024
@mariannuar mariannuar added the 👍 Ready for Review Work is ready for review. label Sep 17, 2024
Base automatically changed from convert-components-to-sdc to main October 23, 2024 16:35
@robherba robherba added 👁 Review in progress Under review. and removed 👍 Ready for Review Work is ready for review. labels Nov 11, 2024
robherba
robherba approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@robherba robherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Mari, it looks good! Just make sure to fix the merge conflicts before merging.

@robherba robherba added 🎉 Passes Functional Review Functionality is approved by the reviewer. 🎉 Passes Code Review Code is approved by the reviewer. and removed 👁 Review in progress Under review. labels Nov 11, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for emulsify-ui-kit ready!

Name Link
🔨 Latest commit 769d2cd
🔍 Latest deploy log https://app.netlify.com/sites/emulsify-ui-kit/deploys/673f99556a6161000828348b
😎 Deploy Preview https://deploy-preview-159--emulsify-ui-kit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mariannuar mariannuar merged commit 299bd72 into main Nov 21, 2024
4 checks passed
@mariannuar mariannuar deleted the tooltip branch November 21, 2024 20:37
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robherba robherba robherba approved these changes

@callinmullaney callinmullaney Awaiting requested review from callinmullaney

@amazingrando amazingrando Awaiting requested review from amazingrando

Assignees

@mariannuar mariannuar

Labels
🎉 Passes Code Review Code is approved by the reviewer. 🎉 Passes Functional Review Functionality is approved by the reviewer. released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariannuar @robherba