Design tokens for Utility Menu #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for emulsify-ui-kit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
callinmullaney
requested changes
Sep 10, 2024
There was a problem hiding this comment.
@mariannuar Similar to your tooltip PR. Can you switch this to the convert-components-to-sdc branch and verify only the changes to the currently listed files apply? I'm guessing you may also run into a lot of unintended files changes as well.
callinmullaney
added
👉 Needs Work
…ulsify-ui-kit into utility-menu
mariannuar
added
👍 Ready for Review
robherba
added
👁 Review in progress
robherba
approved these changes
Nov 11, 2024
robherba
added
🎉 Passes Functional Review
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Design tokens for the new Utility Menu component
How to review this pull request