Subtheme #130
Subtheme #130
Conversation
|
"subtheme" tag in emulsify component configuration marking component that belongs to different subthemes. That creates the new possibility to pull all components that belong to a certain subtheme. The main theme that could be built separately from Drupal will contain pagers from different websites and be marked with subtheme tags for different sites. Each smaller site could pull all required components based on the tag with single command even during the CD process. Like, This PR creates an additional command option to pull subtheme. |
|
@fertant Please fill out the details on what this PR does and how to review it and I'll get this added to our team's queue for review. Thanks! |
src/index.ts
Outdated
| .option( | ||
| '-s --subtheme <subtheme>', | ||
| 'This option use name as subtheme to pull group of components from full list of the components' | ||
| ) |
There was a problem hiding this comment.
I think I get the gist of this PR, and would like to get it merged. But I don't think "subtheme" is the right term. Particularly in Drupal, there's already an established concept of what a subtheme is, and this is very different.
I think the term "Component Set" better describes what we're doing here.
So, what do you think about
'-cs --component-set <setname>',
'Use this to Install a pre-defined set of related components from your component library'
There was a problem hiding this comment.
I totally agree with it. Parameters renamed to componentSet.
This PR should go together with emulsify-ds/compound#46
|
Are there any updates for this PR? Do you planning to merge it or someone has more questions to proposed updates? |
Summary
This PR fixes/implements the following bugs/features
Explain the motivation for making this change. What existing problem does the pull request solve?
Documentation Update (required)
If this pull request requires a change to Emulsify documentation, those changes, updates, and/or new information must accompany this pull request.
How to review this PR
Closing issues
Closes #