Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot install the Emulsify UI Kit with the CLI #233

Closed
amazingrando opened this issue Sep 11, 2023 · 5 comments
Closed

[BUG] Cannot install the Emulsify UI Kit with the CLI #233

amazingrando opened this issue Sep 11, 2023 · 5 comments
Assignees
Labels

Comments

@amazingrando
Copy link
Contributor

Describe the bug
I'm trying to install the Emulsify UI Kit component library with the Emulsify CLI and I cannot.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the Standalone installation instructions
  2. Change the following
    emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout [branch/tag/commit] to emulsify system install --repository https://github.com/emulsify-ds/emulsify-ui-kit.git --checkout main
  3. Get the error Unable to install system assets and/or required components: Error: ENOENT: no such file or directory, lstat '/Users/oest/.emulsify/cache/systems/aafceee31da1cd49aa7dc52ebb708c40/compound/src/components/00-base/01-colors'

I updated system.emulsify.json using the instructions in the docs.

Any help would be appreciated. TY.

@amazingrando amazingrando moved this from Incoming to Backlog in Emulsify Project Sep 22, 2023
@mikeethedude mikeethedude self-assigned this Dec 5, 2023
@joetower
Copy link

@mikeethedude and @amazingrando I looked into this and followed Randy's steps to reproduce.

I had a different error message:

emulsify system install --repository https://github.com/emulsify-ds/emulsify-ui-kit.git --checkout main
System configuration errors: [
  {
    keyword: 'required',
    dataPath: '/variants/0',
    schemaPath: '#/properties/variants/items/anyOf/0/required',
    params: { missingProperty: 'components' },
    message: "should have required property 'components'"
  },
  {
    keyword: 'anyOf',
    dataPath: '/variants/0',
    schemaPath: '#/properties/variants/items/anyOf',
    params: {},
    message: 'should match some schema in anyOf'
  }
]

 ERROR  The system install failed due to the validation errors reported above. Please fix the the errors in the "uikit" configuration and try again.

I'm hoping you have ideas as to how to fix this, Mike.

@mikeethedude
Copy link
Contributor

Ah. I think I do actually. Going to look at this soon this week here.

@mikeethedude
Copy link
Contributor

So the error you are getting @joetower is because https://github.com/emulsify-ds/emulsify-ui-kit/blob/main/system.emulsify.json doesn't contain a "components" key inside of the variants object. (See: https://github.com/emulsify-ds/emulsify-cli/blob/develop/src/handlers/systemInstall.ts#L229C40-L229C40) Should we make it so UI Kit provides some info on required components or at at try an empty set of components? Or I can make it so we check if we have components and then skip the whole thing when it isn't setup. (Might be preferred @amazingrando ?)

@mikeethedude
Copy link
Contributor

@amazingrando This would fix this problem from the UI kit side. emulsify-ds/emulsify-ui-kit#115

@amazingrando
Copy link
Contributor Author

Resolved by #115

@github-project-automation github-project-automation bot moved this from Backlog to Done in Emulsify Project Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants