-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic config listener acceptors #328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove QUIC_SETTINGS from acceptor
Pull Request Test Coverage Report for Build 12292086247Details
💛 - Coveralls |
This was referenced Dec 12, 2024
zmstone
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR combines:
#327
#308
Because #308 is needed for CI to pass.
target v0.2.x
server side conn configs are deferred to set at handshake time instead of spawn(accept) time.
New:
new async_handshake/2
Support override the conn opts just before the handshake.
New listener scope conf table for handshake the new incoming connections.
New quicer_connection:start_acceptor which supports proc_start_opts and deprecating the old start_link for server.
New quicer_listener:get_conf/2
New experimental API: quicer:probe/2 for probe the connection state with 0 len unreliable datagram
Breaking changes:
c struct ACCEPTOR no longer holds the conn settings(opts).
this also reduces the memory footprint per conn acceptor and stream acceptor.
async_accept/2 ignore the 2nd arg which was for conn opts.
quicer_connection behavior defer the conn settings overrides till handshake.
quicer_listener:reload/2
New acceptors now use the new reloaded config.
other
proper tests range is limited due to microsoft/msquic#4705