fix(add_svc): fix service port error #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rory-Z
force-pushed
the
fix/sync-emqx-port
branch
from
acaa34e to
e293d01
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
+ Coverage 76.80% 77.06% +0.26%
==========================================
Files 68 68
Lines 6173 6191 +18
==========================================
+ Hits 4741 4771 +30
+ Misses 1203 1188 -15
- Partials 229 232 +3 ☔ View full report in Codecov by Sentry. |
Rory-Z
force-pushed
the
fix/sync-emqx-port
branch
2 times, most recently
from
1a12fe2 to
a3198f9
Compare
fix can not update kube service port when user update emqx's port by emqx dashboard. Signed-off-by: Rory Z <[email protected]>
Rory-Z
force-pushed
the
fix/sync-emqx-port
branch
from
a3198f9 to
f33b18c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix can not update kube service port when user update emqx's port by emqx dashboard.