Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OMPL an optional installation #178

Merged
merged 3 commits into from
Nov 21, 2024
Merged

Conversation

thisjustin123
Copy link
Collaborator

Description:

Fixes #177.

If OMPL is not installed, a helpful error message is printed instead of crashing.

I'm not sure if we want that error message to print; perhaps there is a better UX we can provide.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Say something like

THIS IS AN OPTIONAL FUNCTION, WON'T AFFECT YOUR USE
Unable to import OmplManagerAttr. OMPL is likely not installed: skipping.
If you haven't installed OMPL before, install it using python3 -m pip install https://github.com/ompl/ompl/releases/download/prerelease/ompl-1.6.0-cp310-cp310-manylinux_2_28_x86_64.whl
Otherwise, make sure you install the python bindings.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just updated the print message!

image

I'd like to highlight that this will print every time any executable is run, lol. Just wondering if this wall of text might confuse people? That's why I had it kinda short before. But your call!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.. then I think just the first line would work.
Unable...will not affect your use

@YoruCathy
Copy link
Member

Also update the readme with this? Say it's optional
python3 -m pip install https://github.com/ompl/ompl/releases/download/prerelease/ompl-1.6.0-cp310-cp310-manylinux_2_28_x86_64.whl

@thisjustin123
Copy link
Collaborator Author

image

README!

@YoruCathy YoruCathy merged commit 89ce695 into phy-robo-care Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants