Define service container usage in controllers

[PauliusMacernis]

Service classes may be defined in two main ways inside of yaml files:

• Namespace, e.g.: As/A/Namespace/To/The/ServiceClass
• Service Id: as.a.name.of.any.choice.refering.to.the.service.class.in.yaml.file

Therefore it is quite easy to get rid of service container usage in the controller class by simply strong-typing arguments of constructor of a controller with the namespace. However, it is not that easy to get rid of service container if the service id is used instead.

From the very first observations I see that there are couple of ways to go and all of them have trade-offs:

1. It is possible to inject service IDs to constructor of a controller but this would require to turn off autowiring for that particular bundle.
2. It is possible to create another class that wraps all of such "service ids" and inject it into constructor of a controller via autowiring instead.
3. It is possible to just:
   a) Do not use service container in constructor at all, use autowiring with constructor instead.
   b) If the first one (a) is not possible (e.g., pim_catalog.query.product_query_builder_factory_without_permission usage case) then skip using autowiring with constructor completely.
4. ?

It seems that service ids are kind of leftover from the old times when autowiring was not present.
Read more on the entire topic here:
https://symfony.com/doc/3.4/controller/service.html

We need to define a way we do it.