Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create HTML Framework #1

Open
emgal-aguirre opened this issue Aug 25, 2020 · 3 comments
Open

Create HTML Framework #1

emgal-aguirre opened this issue Aug 25, 2020 · 3 comments
Assignees

Comments

@emgal-aguirre
Copy link
Owner

Teammate: Emily

The first step in our project is to start an HTML file.

@TEXWRECKS
Copy link
Collaborator

TEXWRECKS commented Aug 27, 2020

Good work on the file Emily! Good notes for each section. I'm leaving a few notes to update, in case you wanted to perform those updates, to consider this complete:

  1. Line 18: The stylesheet link's href needs to be = "Assets/CSS/style.css" so it can have the right pathway.
  2. Don't forget to provide the link to the reset stylesheet at "Assets/CSS/reset.css".

@TEXWRECKS
Copy link
Collaborator

The header and description are within a container, which is good! If you could insert a container on line 42, and close it on line 108, after the last tag, before the tag, that will allow us to have a container for the Value, Convert Value From, Convert Value To, Convert and Reset buttons, and Result.

@TEXWRECKS
Copy link
Collaborator

Please give the Measurement Conversion Calculator container on line 33 an id... id="header", so that container can be styled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants