Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write a test for pooled inhibition -- started #239

Closed
rcoreilly opened this issue Jun 5, 2023 · 4 comments
Closed

write a test for pooled inhibition -- started #239

rcoreilly opened this issue Jun 5, 2023 · 4 comments

Comments

@rcoreilly
Copy link
Member

rcoreilly commented Jun 5, 2023

shows up in the bench_objrec model. None of our tests use pool 4D layers -- will write one for this.

@rcoreilly
Copy link
Member Author

false alarm -- nmda variation again it seems. the real culprit was dwt submean.

@rcoreilly rcoreilly changed the title Pooled inhibition is wrong on GPU write a test for pooled inhibition -- started Jun 6, 2023
@rcoreilly
Copy link
Member Author

really need this test -- it looks like Lvis (which massively uses pooled inhibition) is behaving very differently on GPU in layer V2 which depends critically on pooled inhib.

@rcoreilly
Copy link
Member Author

fix for divergence in v2: 9448f4d

Now Lvis CPU vs. GPU are nearly identical, except for the the critical output layer when increasing NData higher. crazy.

did thorough test in pool_test with large layers and ndata = 8 and GABAB, NMDA set to 0 (to avoid contamination) -- Gi does not diverge, but other things are a bit diff still (INet) -- this is just an unavoidable issue apparently: #237

@rcoreilly
Copy link
Member Author

found the issue affecting Lvis -- this should be all good now and test is robust with large scale test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant