Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests url #2191

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix tests url #2191

merged 2 commits into from
Dec 10, 2024

Conversation

patricklx
Copy link
Contributor

fixes #2150

@ef4
Copy link
Contributor

ef4 commented Dec 3, 2024

This behavior is good, it should probably go in a different place though. The assets plugin is specifically for supporting v1 addon assets, and it won't be included if people drop classic ember support.

@patricklx patricklx force-pushed the fix-tests-url branch 2 times, most recently from 74f3b66 to 0192c27 Compare December 4, 2024 09:24
@mansona mansona added the enhancement New feature or request label Dec 10, 2024
@ef4 ef4 merged commit 6caeed4 into embroider-build:main Dec 10, 2024
213 checks passed
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localhost:4200/tests (without trailing slash) not working with Vite
3 participants