Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GJS Codemod] some imports are duplicated #2182

Open
NullVoxPopuli opened this issue Nov 22, 2024 · 3 comments
Open

[GJS Codemod] some imports are duplicated #2182

NullVoxPopuli opened this issue Nov 22, 2024 · 3 comments

Comments

@NullVoxPopuli
Copy link
Collaborator

Example
image

while this works, and is "correct", it's suboptimal

@void-mAlex
Copy link
Collaborator

void-mAlex commented Nov 22, 2024

do you have the helper at different positions in the template like

{{format-message ... }}
{{fn this.something (format-message ... )}}

?

@NullVoxPopuli
Copy link
Collaborator Author

not quite, but I have:

<Comp @arg={{format-message 'boop'}}>
  {{format-message "boop"}}
</Comp>

@void-mAlex
Copy link
Collaborator

yes those are in different positions and I expect that is why this behaviour is observed
it is technically valid output, but I will see what can be done about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants