Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment step is missing. #134

Closed
andrasio opened this issue Feb 19, 2020 · 3 comments
Closed

Deployment step is missing. #134

andrasio opened this issue Feb 19, 2020 · 3 comments

Comments

@andrasio
Copy link

andrasio commented Feb 19, 2020

I wasn't sure where to ask (there is another super-rentals repository under ember-learn)

If you browse the ember learn site here.

You will see "Follow our tutorial to build, and deploy, your first Ember.js application!" next to the Tutorial link (the super-rentals guide containing Part 1 and Part 2)

The guide ends Part 2 with Provider Components and Recap sections and no other sections (At least I wasn't able to find) contains guide for deploying.

On the other hand, clicking on "Quick Start Guide" does cover deployment.

Also, I'm using Safari and if you browse specifically a section of the super-rentals tutorial the sidebar on the left under "Tutorial" is not collapsed by default (maybe it should be or maybe not).

@chancancode
Copy link
Collaborator

Hi @andrasio you are right, that chapter is currently missing. I've opened #137 to collect the ideas of what needs to be covered. Assuming you got to the end of the last chapter, the app should be ready for deployment using Netlify (or other similar services like Heroku). Do you mind giving Netlify a go, and document any thoughts, friction, questions, problems etc on issue #137 so we know what we need to cover there?

@andrasio
Copy link
Author

@chancancode Thanks! Sure, will do so.

@andrasio
Copy link
Author

@chancancode Netlify deployment went smoothly. Not much to say regarding that for the issue #137.

@andrasio andrasio reopened this Feb 24, 2020
@andrasio andrasio closed this as completed Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants