Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove discussion of old debug handler polyfill, it's been a minute #2062

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

acorncom
Copy link
Member

@acorncom acorncom commented Oct 9, 2024

As part of discussing emberjs/rfcs#1009, I took another look at the deprecation workflows page. I don't think we need to recommend installing the pre 2.1 deprecation workflow polyfill any more ... 😉

Not least because it's archived and likely won't even working in the last few versions of Ember: https://github.com/ember-polyfills/ember-debug-handlers-polyfill

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit 210cc52
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/6706ea502b3037000825f61d
😎 Deploy Preview https://deploy-preview-2062--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acorncom acorncom changed the title Remove discussion of Ember 2.1, it's been a minute Remove discussion of old debug handler polyfil, it's been a minute Oct 9, 2024
@acorncom acorncom changed the title Remove discussion of old debug handler polyfil, it's been a minute Remove discussion of old debug handler polyfill, it's been a minute Oct 9, 2024
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@mansona mansona merged commit 4563b16 into master Oct 10, 2024
4 checks passed
@mansona mansona deleted the acorncom-patch-1 branch October 10, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants