404 error clicking on old-version-warning btn link on v1.10.0

[shroy]

When navigating to Views: Inserting Views in Templates v1.10.0, the VIEW v3.1.0 link returns a 404 error.

Error message in the response..

Error: Ember Data Request GET /content/v3.1.0/views/inserting-views-in-templates/index.json returned a 404 Payload (Empty Content-Type)

[mansona]

Hey @shroy 👋 thanks for the report

Right now this is very roughly in the bucket of "expected behaviour" but I agree it's not a great experience at all.

Do you have an expectation of what you would have expected to happen instead of what it's doing right now? I would love your feedback because it clearly feels wrong to you right now 🤔

[shroy]

Hey @mansona, I should have provided that info! My bad.. 🏸

Visiting the site as someone who is new to Ember, I had expected the link to direct me to an updated version on the topic of Views: Inserting Views in Templates; however, given the page no longer exists in the new docs, I can imagine a couple scenarios when clicking that link..

1. The user is directed to the first chapter for the latest version with a flash alert/notice (similar to the (old-version-warning) explicitly letting the user know the expected page no longer exists in the latest version. *This option lets the user know the behavior was expected, guiding them to the latest version while alleviating suspicious thoughts that the page might live somewhere in the new version's content.

2. The user is directed to a page that provides suggested topics (or auto-searched results) available in the latest version. I can imagine the backend could query said results using keywords from the previously viewed chapter's title. *Personally, I find this to be the most desirable option; it speeds up the process of helping the user find what they need.

I hope this makes sense. Let me know if you'd like me to provide more detail. Appreciate your work on this incredible resource!

[mansona]

@shroy thanks for this, it is exactly what I was hoping for 😄

I think there is also a third option, which would probably be a little bit more time intensive so it might be a non-runner. We could add some metadata to the old guide pointing at exactly where it should redirect. For example, the one that you're testing out here views/inserting-views-in-templates should probably point at components because that is the closest concept to a view nowadays (ish).

@shroy would you be interested in championing this implementation? I would love to help you get started on it and guide you through the process if you're interested. The first step would be bringing it to the team (maybe on the weekly meeting) to see what people thought was the best way forward out of the three options.

[shroy]

@mansona that sounds like a great third option 👍

I would be glad to help with the implementation if some patience is afforded 🙂 I am currently a new hire learning Ember alongside a monolithic codebase, yet could use the extra hands on experience.

[acorncom]

@shroy We'd love to get the help 😄 We find for some things it's easier to discuss things in real-time (the fact that this issue has slipped through the cracks is a good example of why 😉 ) Have you signed up for an Ember Slack account? We discuss a lot of ad-hoc items in #-team-learning if you want to sign in and ask questions about this. Might also be worth referencing the issue so we have some idea of what you're talking about 😁

[shroy]

@acorncom I do have an account with that channel 🙂 I'll prompt the discussion with this issue as the reference soon. Thanks!

[anotheredward]

I've been wanting to fix this issue for a while, any progress @shroy ?

[shroy]

@anotheredward @acorncom @mansona

Copied from Slack posting:

Hello! I posted a github issue long ago which prompted a conversation around linking old deprecated/irrelevant/greatly-changed ember guide topics with new related ones. You could read about it here: https://github.com/ember-learn/guides-app/issues/132

I was asked to take on this implementation but underestimated the time I'd need to feel comfortable at my new position. I'm still happy to participate in conversations and help in anyway I can.

Apologies for keeping this issue in limbo!

Sorry for the wait!

[mansona]

@shroy firstly: I copied the content of your slack posting to this issue before it got swallowed up when we lost history 😖

secondly: no need for any apologies! we're all busy people and it can sometimes be hard to find time for open source stuff when we've got full-time jobs that aren't just paying us to do open source 100% of the time 😂 (that would be lovely tho)

[anotheredward]

@mansona I'll implement this, let's catch up soon and run through some options :).

I've been working on a related issue that could be made simpler by a more user-friendly 404 strategy:
https://github.com/ember-learn/guides-app/pull/200/files

[MelSumner]

@anotheredward and @mansona let's figure out if there's a path forward for this- I verified tonight that the issue still exists. Thank you! 👍

[anotheredward]

Thanks for reminding me of this @MelSumner .
As far as I understand, we have two options:

1. Change the link button code to use the same logic as the version changer from my PR: Remove jQuery from component lifecycle #200 :
   Stay on same page when transitioning between Ember Versions guides-app#200 . This change is simple, and duplicates a bit of logic.

2. Move the logic I added up to where we handle 404s, that way we'll do a best guess no matter when the user comes from (eg: An old-link on a different site).
   This change requires less duplication, and fixes a potential issue with external urls using the release version, but I am not sure what knock-on effects it might have.

Normally this wouldn't be a problem as a URL like:
https://guides.emberjs.com/v1.10.0/views/inserting-views-in-templates/
Should always be correct, that page will always exist for that specific version.

But the potentially problematic case is for external links is when a user uses the release version with a specific page:
https://guides.emberjs.com/release/views/inserting-views-in-templates/

Not sure if this is worth fixing, but it's worth being aware of :).

[mansona]

Hi @anotheredward 👋 sorry I didn't notice that you were linking to the guides-app repo before now 🙈

The guides app repo no longer powers the templates for the ember guides, we are now using https://github.com/ember-learn/guidemaker-ember-template

I hope there hasn't been too much wasted effort 😫 this is entirely my fault for not updating the relevant contributing guides to point to the new place. Let me know if you need any help to get started with the new system, it should hopefully be a bit easier to work with than the old guides-app infrastructure

[anotheredward]

@mansona Thank you for your responses and for archiving the project to avoid future issues :).
There hasn't been much wasted effort, and I'll be glad to reflect the same changes in the newer repositories :).

[MinThaMie]

Will close this issue because it will be/has to be solved in ember-learn/guidemaker-ember-template#17