Fix sidebar-weirdness

[MinThaMie]

• negative margin magic in the guidemaker-template
• mobile styling needed in API docs
• word-wrapping for API menu items that don't include slashes

All of the fixes for these cases should go in the sidebar or table of contents CSS here in the styleguide (if we can)

[Shub3am]

Hey I was willing to work on this issue, can you reiterate where the guidemaker-template is?

[MinThaMie]

So the guidemaker-template lives here: https://github.com/ember-learn/guidemaker-ember-template

[lukasnys]

I'll pick this up!

[lukasnys]

I know it's 3 months later but I'm picking this back up 💀

word-wrapping for API menu items that don't include slashes

This point should likelly become "word-wrapping for API menu items that don't include dashes" as the word wrapping happens on dashes but not slashes.

[lukasnys]

@MinThaMie @mansona do either of you have an idea on the best way to about the word wrapping? Maybe a naïve approach, but could we just increase the sidebar width and decrease its padding to create more space?

e.g. the following screenshot uses a padding of var(--spacing-2);/1.125rem (instead of the current var(--spacing-4);/2.25rem) and a sidebar width of 21rem instead of the current 18.5rem.

If you are okay with this approach, I propose to change this directly in the ember-styleguide. Let me know what you think

[MinThaMie]

Should be fixed by #507

[mansona]

We will need to update to ember-styleguide@10 to get the new stuff 👍

[lukasnys]

I upgraded to ember-styleguide@9 and cleaned up the redundant styles in ember-learn/guidemaker-ember-template#172. Ignace has already approved this but it could use another pair of eyes.

I upgraded to ember-styleguide@10 and removed the negative margin hack in ember-learn/guidemaker-ember-template#171 if either of you could have a look 🙏 (which I based on PR 172, but I can't figure out how to base my PR onto that one so it shows changes for both PRs)

[mansona]

do we still need this issue now that #171 is merged?

[mansona]

turns out not! we can close this 🎉