Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "webpage" wrapper for around images #466

Open
mansona opened this issue Jul 6, 2023 · 2 comments
Open

Create a "webpage" wrapper for around images #466

mansona opened this issue Jul 6, 2023 · 2 comments

Comments

@mansona
Copy link
Member

mansona commented Jul 6, 2023

In the guides we now have images that have a very similar background colour as the guides themselves e.g. https://guides.emberjs.com/release/tutorial/part-1/orientation/

We should have some way to "wrap" these images in a browser window, keeping in mind this needs to work somehow with Markdown so we may need to implement some custom showdown extension for it 👍

@mansona mansona converted this from a draft issue Jul 6, 2023
@MelSumner
Copy link
Member

@mansona can you clarify- do you want some CSS to add a border or similar, or an actual component or div element wrapper?

@mansona
Copy link
Member Author

mansona commented Jul 6, 2023

So it needs to work in a markdown context so I would suggest that it needs to be a CSS class or just some plain HTML and CSS that we can add when we know we need it from a showdown extension 🤔 i.e. it can't be an Ember Component 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants