Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing entire file github url in docs #25

Open
sivakumar-kailasam opened this issue Mar 15, 2017 · 0 comments
Open

Providing entire file github url in docs #25

sivakumar-kailasam opened this issue Mar 15, 2017 · 0 comments

Comments

@sivakumar-kailasam
Copy link
Member

At present in the ember app we construct the github url of a file by checking its project name and the appending the partial file url from the docs we generate. This doesn't handle scenarios where the docs refers to classes such as rsvp, inflector which are ember libraries that are external dependencies for ember & ember-data. In such cases the file url is defined as node_modules/rsvp/index.js which will be broken when user accesses it.

We should handle these scenarios & update the docs with a full & functional github url so that the ember app can just provide the link to the user without any computation at its end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants