-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate a manifest file per project version #22
Comments
@toddjordan You can assign this to me since I'm anyway restructuring the folders & generation logic |
I could be talked out of splitting the manifest.json into namespaces, modules, and classes. We'd be providing this info in the nav.json. Really the manifest.json would be used for hydrating the cache, and would be store by a key composed of an aggregate project-version-name (and possibly type) {
"items": [ { "name": "Ember.FEATURES",
"type": "namespace",
"url": "URL_TO_NAMESPACE_JSON" },
{ "name": "ember-debug",
"type": "module",
"url": "URL_TO_MODULE_JSON"},
{ "name": "Ember.Engine",
"type": "class",
"url": "URL_TO_CLASS_JSON"}
]
} |
in its current form a gzipped manifest of ember 2.11 comes up to 1kb. So we might be good for now to stick to the collated form. The manifest contains all the info mentioned in nav.json as well. Here's one in its existing form - https://gist.github.com/sivakumar-kailasam/07f33517f440bfd9a8dc417efa98383d. |
I don't think that removing classes/namespaces/modules will make it bigger. Looks bigger above because we added type (not sure we'll need yet). I'd rather design the json for use by the client rather than size, as I don't think the peformance difference between 1 and 10kb will be noticable. also, the "types" may change with js modules rfc. |
Fixed by #21 |
This file will be a guide to what files exist in a given project version.
It will be used by the client for 2 purposes:
I think these might need to be 2 separate files.
One file can list all the files, the other can be used for relationships. Here's a proposal (open for suggestions)
List (manifest.json):
A relationship tree would be interesting... it would be used to populate the left nav and have enough info to specify the route we would go to if we clicked on the item.
pre-javascript module rfc Relationships (nav.json):
This would allow both Classes and submodules/packages to be children, which wouldn't be an issue pre-js module rfc, but would after, and would allow eventually for classes, method, and properties to be listed.
The text was updated successfully, but these errors were encountered: