-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stub out deprecation files #954
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
19 changes: 19 additions & 0 deletions
19
content/ember/v3/deprecated-run-loop-and-computed-dot-access.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
id: deprecated-run-loop-and-computed-dot-access | ||
title: Run loop and computed dot access | ||
until: '5.0.0' | ||
since: '3.27.0' | ||
--- | ||
|
||
Using `.` to access computed or run loop functions has been deprecated, such | ||
as `computed.filter`. | ||
Instead, import the value directly from the module: | ||
|
||
```js | ||
import { filter } from '@ember/object/computed'; | ||
``` | ||
|
||
(This deprecation guide needs more details. | ||
You can help out by editing | ||
[this file](https://github.com/ember-learn/deprecation-app/blob/main/content/ember/v3/deprecated-run-loop-and-computed-dot-access.md) | ||
and making a PR!) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
--- | ||
id: ember-env.old-extend-prototypes | ||
title: Old extend protptypes | ||
until: '5.0.0' | ||
since: '3.3.0' | ||
--- | ||
|
||
Accessing `Ember.EXTEND_PROTOTYPES` is deprecated, please migrate to `Ember.ENV.EXTEND_PROTOTYPES`. | ||
|
||
(This deprecation guide needs more details. | ||
You can help out by editing | ||
[this file](https://github.com/ember-learn/deprecation-app/blob/main/content/ember/v3/ember-env-old-extend-prototypes.md) | ||
and making a PR!) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
id: ember-source-deprecation-without-for | ||
title: Without for | ||
until: '4.0.0' | ||
since: '3.24.0' | ||
--- | ||
|
||
(This deprecation guide needs details. | ||
You can help out by editing | ||
[this file](https://github.com/ember-learn/deprecation-app/blob/main/content/ember/v3/ember-source-deprecation-without-for.md) | ||
and making a PR!) |
12 changes: 12 additions & 0 deletions
12
content/ember/v3/ember-source-deprecation-without-since.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
--- | ||
id: ember-source-deprecation-without-since | ||
title: Without since | ||
until: '4.0.0' | ||
since: '3.24.0' | ||
--- | ||
|
||
(This deprecation guide needs more details. | ||
You can help out by editing | ||
[this file](https://github.com/ember-learn/deprecation-app/blob/main/content/ember/v3/ember-source-deprecation-without-since.md) | ||
and making a PR!) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
id: old-deprecate-method-paths | ||
title: Old deprecate method imports | ||
until: '4.0.0' | ||
since: '3.0.0' | ||
--- | ||
|
||
Importing `deprecate` from `@ember/application/deprecations'` | ||
has been deprecated. Please update to `import { deprecate } from '@ember/debug'`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
--- | ||
id: template-compiler.registerPlugin | ||
title: Class-based template compilation plugins | ||
until: '5.0.0' | ||
since: '3.27.0' | ||
--- | ||
|
||
Using class based template compilation plugins is deprecated. | ||
Please update to the functional style. | ||
|
||
(This deprecation guide needs more details. | ||
You can help out by editing | ||
[this file](https://github.com/ember-learn/deprecation-app/blob/main/content/ember/v3/template-compiler-registerPlugin.md) | ||
and making a PR!) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
id: ember.link-to.disabled-when | ||
title: Passing disabledWhen to LinkTo | ||
until: '5.0.0' | ||
since: '4.0.0' | ||
--- | ||
|
||
Passing the `@disabledWhen` argument to <LinkTo> is deprecated. Use the `@disabled` argument instead.' |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should these versions be? See PR emberjs/ember.js#19748 and emberjs/ember.js#19748