-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation guides for deprecating importing from `'ember'' #1381
base: main
Are you sure you want to change the base?
Deprecation guides for deprecating importing from `'ember'' #1381
Conversation
✅ Deploy Preview for ember-deprecations ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Looks like there is an issue with case sensitivity in the build:
that'll need to get fixed -- as the URLs / ids are generated from the real property names 😅 Happens here: https://github.com/emberjs/ember.js/pull/20686/files#diff-aa3f9176575f028f979266539b2a7647d98ec70c72162bd89de74f863c857f8bR95 |
Hey! Is there anyway we can dasherize and lowercase the importName in your implementation? I think most of the other deprecation ids follow that format. |
I suppose, but it introduces risk of not matching 1-1, due to potential for variances in implementation of how dasherize works. |
7f8d6c3
to
1a984b2
Compare
It is done tho |
RFC: emberjs/rfcs#1003 Guide: ember-learn/deprecation-app#1381 Advancement: emberjs/rfcs#1015
@NullVoxPopuli It looks like this is labeled as since 5.10 but I don't see this in the 5.10 release notes. @kategengler Did we actually get this in? Maybe I'm missing something. |
No, it didn't make it to 5.10 (and thus will be until 7.0 at the earliest). It is available but not enabled right now. |
RFC: emberjs/rfcs#1003
Implementation: emberjs/ember.js#20686
Advancement: emberjs/rfcs#1015