Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation guides for deprecating importing from `'ember'' #1381

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

RFC: emberjs/rfcs#1003
Implementation: emberjs/ember.js#20686

Advancement: emberjs/rfcs#1015

Copy link

netlify bot commented May 2, 2024

Deploy Preview for ember-deprecations ready!

Name Link
🔨 Latest commit 3ab4602
🔍 Latest deploy log https://app.netlify.com/sites/ember-deprecations/deploys/669156341cb59e0008e9ae1f
😎 Deploy Preview https://deploy-preview-1381--ember-deprecations.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review May 3, 2024 21:53
@NullVoxPopuli
Copy link
Contributor Author

NullVoxPopuli commented May 3, 2024

Looks like there is an issue with case sensitivity in the build:

Merge error: conflicting capitalizations:
deprecate-import-Debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api
deprecate-import-debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api

that'll need to get fixed -- as the URLs / ids are generated from the real property names 😅

Happens here: https://github.com/emberjs/ember.js/pull/20686/files#diff-aa3f9176575f028f979266539b2a7647d98ec70c72162bd89de74f863c857f8bR95

@jaredgalanis
Copy link
Member

jaredgalanis commented May 6, 2024

Looks like there is an issue with case sensitivity in the build:

Merge error: conflicting capitalizations:
deprecate-import-Debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api
deprecate-import-debug-from-ember.json in /tmp/broccoli-1942Am0NkS0JmM5b/out-417-mark_down_to_json_api

that'll need to get fixed -- as the URLs / ids are generated from the real property names 😅

Happens here: https://github.com/emberjs/ember.js/pull/20686/files#diff-aa3f9176575f028f979266539b2a7647d98ec70c72162bd89de74f863c857f8bR95

Hey! Is there anyway we can dasherize and lowercase the importName in your implementation? I think most of the other deprecation ids follow that format.

@NullVoxPopuli
Copy link
Contributor Author

Hey! Is there anyway we can dasherize and lowercase the importName in your implementation? I think most of the other deprecation ids follow that format.

I suppose, but it introduces risk of not matching 1-1, due to potential for variances in implementation of how dasherize works.

@NullVoxPopuli NullVoxPopuli force-pushed the guide-for-deprecate-import-from-ember branch from 7f8d6c3 to 1a984b2 Compare May 6, 2024 16:26
@NullVoxPopuli
Copy link
Contributor Author

It is done tho

NullVoxPopuli added a commit to NullVoxPopuli/ember.js that referenced this pull request May 10, 2024
@jaredgalanis
Copy link
Member

@NullVoxPopuli It looks like this is labeled as since 5.10 but I don't see this in the 5.10 release notes. @kategengler Did we actually get this in? Maybe I'm missing something.

@kategengler
Copy link
Contributor

No, it didn't make it to 5.10 (and thus will be until 7.0 at the earliest). It is available but not enabled right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants