Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change field names in shortenedurl table #2

Open
emasters opened this issue Apr 15, 2012 · 1 comment
Open

Change field names in shortenedurl table #2

emasters opened this issue Apr 15, 2012 · 1 comment
Assignees

Comments

@emasters
Copy link
Owner

  • created -> create_date
  • creator -> creator_ip
  • add last_use_date

shorten.php will need to be modified to reflect these changes.

@ghost ghost assigned emasters Apr 15, 2012
@bdereta
Copy link

bdereta commented Feb 22, 2013

Nice code! I found a smaller issue in the shortenedurls.sql, LINE 25 reads: PRIMARY KEY (pkId). MySQL will throw an error: [Err] 1072 - Key column 'pkId' doesn't exist in table. It should read PRIMARY KEY (pkUserId).

One more thing: Your register method doesn't check if the user (email) already exists, which means a user can open multiple accounts with the same email address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants