borg-build magit will get error: Invalid face box

[Eason0210]

@tarsius

I try to build magit with M-x borg-build magit on latest magit and borg, will get below error:

lib/magit/lisp/git-commit.el:125:2: Error: Invalid face box: :line-width, -1, :color, unspecified

I am not sure it is the issue from borg or magit.

I also tried make clean && make build, it works as expected, no error and warninings.

Emacs version:
GNU Emacs 30.0.50 (build 1, x86_64-apple-darwin23.1.0, NS appkit-2487.20 Version 14.1.2 (Build 23B92), git sha1 fb4b0b30a24) of 2023-12-03

(17:24:09) Building magit

Initializing drones...done (69 drones in 0.072s)
 Creating /Users/eason0210/.emacs.d/lib/magit/lisp/magit-autoloads.el...
 Skipping /Users/eason0210/.emacs.d/lib/magit/lisp/git-commit-pkg.el...skipped
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/git-commit.el...

In toplevel form:
lib/magit/lisp/git-commit.el:125:2: Error: Invalid face box: :line-width, -1, :color, unspecified
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/git-rebase.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-apply.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-autorevert.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-base.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-bisect.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-blame.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-bookmark.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-branch.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-bundle.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-clone.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-commit.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-core.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-diff.el...

In magit-diff-toggle-file-filter:
lib/magit/lisp/magit-diff.el:1467:8: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1

In magit-diff-type:
lib/magit/lisp/magit-diff.el:3071:13: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-ediff.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-extras.el...

In magit--read-repository-buffer:
lib/magit/lisp/magit-extras.el:892:27: Warning: ‘derived-mode-p’ called with 4 arguments, but accepts only 1
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-fetch.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-files.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-git.el...

In magit-commit-at-point:
lib/magit/lisp/magit-git.el:1575:13: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1

In magit-branch-or-commit-at-point:
lib/magit/lisp/magit-git.el:1602:13: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-gitignore.el...
 Skipping /Users/eason0210/.emacs.d/lib/magit/lisp/magit-libgit-pkg.el...skipped
 Skipping /Users/eason0210/.emacs.d/lib/magit/lisp/magit-libgit.el...skipped
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-log.el...

In magit-log-trace-definition:
lib/magit/lisp/magit-log.el:812:23: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

In magit-log-wash-log:
lib/magit/lisp/magit-log.el:1315:10: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

In magit-log-wash-rev:
lib/magit/lisp/magit-log.el:1330:10: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

In magit-log-maybe-update-revision-buffer:
lib/magit/lisp/magit-log.el:1501:10: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1

In magit-log-maybe-update-blob-buffer:
lib/magit/lisp/magit-log.el:1529:10: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-margin.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-merge.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-mode.el...

In magit-display-buffer-same-window-except-diff-v1:
lib/magit/lisp/magit-mode.el:673:18: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

In magit-display-buffer-fullframe-status-topleft-v1:
lib/magit/lisp/magit-mode.el:731:14: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

In magit-display-buffer-fullcolumn-most-v1:
lib/magit/lisp/magit-mode.el:756:21: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1

In magit-mode-quit-window:
lib/magit/lisp/magit-mode.el:945:34: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

In magit-preserve-section-visibility-cache:
lib/magit/lisp/magit-mode.el:1361:10: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-notes.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-patch.el...
 Skipping /Users/eason0210/.emacs.d/lib/magit/lisp/magit-pkg.el...skipped
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-process.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-pull.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-push.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-reflog.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-refs.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-remote.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-repos.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-reset.el...
 Skipping /Users/eason0210/.emacs.d/lib/magit/lisp/magit-section-pkg.el...skipped
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-section.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-sequence.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-sparse-checkout.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-stash.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-status.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-submodule.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-subtree.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-tag.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-transient.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-wip.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit-worktree.el...
Compiling /Users/eason0210/.emacs.d/lib/magit/lisp/magit.el...
Done (Total of 45 files compiled, 1 failed, 5 skipped)
  Running ‘makeinfo --no-split magit-section.texi -o magit-section.info’...
  Running ‘makeinfo --no-split magit-section.texi -o magit-section.info’...done
  Running ‘makeinfo --no-split magit.texi -o magit.info’...
  Running ‘makeinfo --no-split magit.texi -o magit.info’...done
  Running ‘install-info magit-section.info --dir=dir’...
  Running ‘install-info magit-section.info --dir=dir’...done
  Running ‘install-info magit.info --dir=dir’...
  Running ‘install-info magit.info --dir=dir’...done

Process emacs ... --eval (borg-build "magit") finished

[tarsius]

Thanks for the report.

magit/transient@413310c should fix that.

(I've also updates borg to silence the warnings about derived-mode-p. Another instance where we cannot satisfy all Emacs releases at the same time without jumping through hoops.)

[Eason0210]

Hi @tarsius

I update transient and borg to latest commit, but the error and warnings still exist, will get the same build log message.

lib/magit/lisp/git-commit.el:125:2: Error: Invalid face box: :line-width, (-1 . -1), :color, unspecified

In magit-diff-toggle-file-filter:
lib/magit/lisp/magit-diff.el:1467:8: Warning: ‘derived-mode-p’ called with 3 arguments, but accepts only 1

In magit-diff-type:
lib/magit/lisp/magit-diff.el:3071:13: Warning: ‘derived-mode-p’ called with 2 arguments, but accepts only 1

[Eason0210]

With latest commit of transient, now it works as expected. Thanks