Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eaf-pdf-viewer: switching to other frame when press any key in tear-off-window frame #1031

Open
ybyygu opened this issue Nov 17, 2022 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@ybyygu
Copy link

ybyygu commented Nov 17, 2022

Describe the bug
eaf-pdf-viewer handles key press signal incorrectly in tear-off-window frame

To Reproduce

  1. open emacs with only eaf loaded

emacs -q -l init-eaf.el

  1. load eaf-pdf-viewer module:

(require 'eaf)
(require 'eaf-pdf-viewer)

  1. create a new frame using tear-off-window

M-x dired-jump-other-window
M-x tear-off-window

  1. open a pdf file using eaf-pdf-viewer in new window (the one that teared off)

M-x eaf-open; open minif.pdf

  1. scroll the pdf view using hjkl keys. It is normal at first.
  2. switch to other emacs frame (or other GUI window) and then switch back
  3. scroll the pdf view again using hjkl keys: now any key press will turn you back to other emacs frame automatically, meanwhile the mouse scroll behave normally.

Expected behavior
pressing hjkl keys in eaf-pdf-viewer buffer should scroll the view, but not switch to other emacs frame

Versions (please complete the following info):

  • Distro and DE/WM: KDE
  • Versions of Dependencies:
  • M-x emacs-version: 28.2

Error logs
Please check the *eaf* buffer, if there is any error in it, paste it here.

Screenshots
the eaf I used:
image

@manateelazycat
Copy link
Member

EAF not support popup frame now, any PR are welcome.

@ybyygu
Copy link
Author

ybyygu commented Nov 17, 2022

Thank you for your guide. I will learn and hack on this direction.

EAF not support popup frame now, any PR are welcome.

@manateelazycat manateelazycat added the help wanted Extra attention is needed label Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants