Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(capture)!: add filter function opt for fields #44

Closed
wants to merge 1 commit into from
Closed

Conversation

bdarcus
Copy link
Contributor

@bdarcus bdarcus commented Apr 7, 2023

  • citar-org-roam-template-fields: convert from cons to list

Close: #43


Needs testing, and probably to add some default filter functions.

* citar-org-roam-template-fields: convert from cons to list

Close: #43
@bdarcus
Copy link
Contributor Author

bdarcus commented Aug 6, 2023

Need to get back to merging this!

On the default filter functions (in part to ensure it works correctly), what might they be?

Any thoughts @roshanshariff?

I suppose another option is non-breaking: to add a new defcustom specifically for this, and keep the existing one the same.

@roshanshariff
Copy link
Contributor

I'll look at this more deeply in a few days, but I wonder if most of this functionality should be in Citar? It could be useful to define some "virtual fields" there which are basically some bibliography fields, transformed by a filter function. You might want to use these in Citar templates as well. Perhaps citar-org-roam should just expose these Citar fields in Org-Roam templates?

@bdarcus
Copy link
Contributor Author

bdarcus commented Aug 7, 2023

Yeah, I was thinking something in citar itself might be better, but just not sure how that might work.

There's no real urgency here; just wanted to resolve this, since it's been sitting here awhile.

Use cases I'm thinking about are in the linked issue.

@bdarcus
Copy link
Contributor Author

bdarcus commented Sep 13, 2023

I'm going to close this in favor of the core package-only transform functions.

@bdarcus bdarcus closed this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional filter function to citar-org-roam-template-fields
2 participants