Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ideal markup? #167

Open
sheriffderek opened this issue Apr 4, 2017 · 1 comment
Open

Ideal markup? #167

sheriffderek opened this issue Apr 4, 2017 · 1 comment

Comments

@sheriffderek
Copy link

sheriffderek commented Apr 4, 2017

I'm not sure how much markup is already in the component, but as an outsider - this is the markup I would hope for:

<ul class='tumblr-post-list'>
{{#each tumblrPosts as |post|}}
  <li class='tumblr-post {{post.type}}'>
    <article class='post-content'>
      {{post.content}}
    </article>
  </li>
{{/each}}
</ul>
.tumblr-post.video {
  key: value;
}

I know it's hard to navigate the ember-view inclusions -


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@elwayman02
Copy link
Owner

elwayman02 commented Apr 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants