Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getAuthenticatorName doesn't seem to work #12

Open
1 task
elliot-sawyer opened this issue Jun 5, 2018 · 3 comments
Open
1 task

getAuthenticatorName doesn't seem to work #12

elliot-sawyer opened this issue Jun 5, 2018 · 3 comments
Labels

Comments

@elliot-sawyer
Copy link
Owner

elliot-sawyer commented Jun 5, 2018

Believe this affects firesphere/silverstripe-bootstrapmfa as well. The authenticator takes the label of "E-mail & Password" which is inherited from MemberAuthenticator

Pull requests

@robbieaverill robbieaverill self-assigned this Nov 5, 2018
@robbieaverill
Copy link
Collaborator

What should it be? "Email & Password (with MFA)"?

@robbieaverill
Copy link
Collaborator

On the login screen you are given the BootstrapMFA login form, which uses its own authenticator name (see PR above). If you overload LoginForm in TOTPLoginHandler to return a TOTPForm instead of a BootstrapMFALoginForm then it will return the authenticator name from this module, but I don't think that's the correct flow. Anyway, I've made a PR above to differentiate the bootstrap module's authenticator from the default.

@robbieaverill robbieaverill removed their assignment Nov 5, 2018
@ScopeyNZ
Copy link
Collaborator

I'm not entirely sure what the follow up here but @Firesphere indicated there are changes to make on this module although it might be addressed in #18 . Can @Firesphere verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants