Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf_generate and FileDescriptor #39

Open
mjheilmann opened this issue Jun 11, 2024 · 0 comments
Open

protobuf_generate and FileDescriptor #39

mjheilmann opened this issue Jun 11, 2024 · 0 comments

Comments

@mjheilmann
Copy link
Collaborator

We have code to compensate for the service definitions of protobuf_generate being a FileDescriptorProto instead of a ServiceDescriptorProto. But we handle it by simply extracting the ServiceDescriptorProto and passing that into the original builder code.

When we are presented with a FileDescriptorProto, we should use it directly as a reflection payload instead of ignoring the FileDescriptorProto and simulating our own. ref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant