Feature/decorator routing #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* avoid having to forcefully require components * avoid namespace/path collisions more elegantly * make ordering pages (regarding navbar) easily feasable
DominikHorn
requested review from
FabianWildgrube,
AlexanderZellner,
maxammann,
ricffb and
SimonKostin98
toschmidt
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core idea was to replace the rather imperative routing code with declarative decorator-driven design. Turns out this is not ideal:
All surviving changes from this ticket aim to enhance the routing code/prepare it for future code modularization steps
closing #13