Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for eoed-docs.eliatra.com #2

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Conversation

pchmielnik
Copy link

Description

Describe what this change achieves.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@pchmielnik pchmielnik changed the title Website ci updated workflow CI for eoed-docs.eliatra.com Feb 19, 2024
@pchmielnik pchmielnik force-pushed the website-ci-updated-workflow branch from 3ed9b5a to 4d1ea2c Compare February 19, 2024 18:28
@pchmielnik pchmielnik force-pushed the website-ci-updated-workflow branch from 5ffce78 to 0ea873d Compare February 20, 2024 15:43
@pchmielnik pchmielnik requested a review from salyh February 20, 2024 15:43
@pchmielnik pchmielnik self-assigned this Feb 20, 2024
@pchmielnik pchmielnik mentioned this pull request Feb 20, 2024
1 task
Copy link
Member

@salyh salyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question regarding different versions:

grafik

I guess we add this workflow to the 1.3.x and 2.11.x branch and each workflow deploys into a separate folder whereas latest points to 2.11? right?

@pchmielnik
Copy link
Author

One question regarding different versions:

grafik I guess we add this workflow to the 1.3.x and 2.11.x branch and each workflow deploys into a separate folder whereas latest points to 2.11? right?

Good question, I see that they have also archived version and every of them have separated folder. Do we want to keep all the version including archived or use the recent one for 2.x and 1.x and the point the archived to most recent 1.x/2.x version?

@salyh
Copy link
Member

salyh commented Feb 22, 2024

I will remove the archive links from the version selector, so we will have only 1.3 and 2.11

@pchmielnik
Copy link
Author

I will remove the archive links from the version selector, so we will have only 1.3 and 2.11

I created the PR for 1.x #3
Additionally, I have changed the nginx settings to redirect requests from docs/2.x to docs/latest and from 1.x to docs/1.x, which currently contains version 1.3. This should minimize instances of dead links.

@salyh salyh merged commit a720db5 into 2.11.x-ee Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants