Update CI workflows to checkout submodules

eliaskosunen · Oct 29, 2023 · ab4a158 · ab4a158
1 parent 00dc891
commit ab4a158
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 5 deletions.
diff --git a/.github/workflows/arch.yml b/.github/workflows/arch.yml
@@ -39,6 +39,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - uses: uraimo/run-on-arch-action@v2
         name: Build and test
@@ -70,6 +72,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: cmake -E make_directory ${{ runner.workspace }}/build
@@ -78,7 +82,7 @@ jobs:
         working-directory: ${{ runner.workspace }}/build
         shell: bash
         run: |
-          cmake -G "${{ matrix.gen }}" -A ${{ matrix.arch }} -DCMAKE_CROSSCOMPILING=ON -DSCN_CI=ON $GITHUB_WORKSPACE
+          cmake -G "${{ matrix.gen }}" -A ${{ matrix.arch }} -DCMAKE_CROSSCOMPILING=ON $GITHUB_WORKSPACE
 
       - name: Build
         working-directory: ${{ runner.workspace }}/build

diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
@@ -33,6 +33,8 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Run CMake
         working-directory: ${{ runner.workspace }}/build

diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml
@@ -156,6 +156,8 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Run CMake
         working-directory: ${{ runner.workspace }}/build
@@ -191,6 +193,8 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: |
@@ -225,6 +229,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Start docker
         run: |
@@ -276,6 +282,8 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Run CMake
         working-directory: ${{ runner.workspace }}/build
@@ -305,6 +313,8 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Build scnlib
         run: |

diff --git a/.github/workflows/lite.yml b/.github/workflows/lite.yml
@@ -50,13 +50,15 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Run CMake
         working-directory: ${{ runner.workspace }}/build
         env:
           CXX: ${{ matrix.cxx }}
         run: |
-          cmake -G Ninja -DSCN_CI=ON -DSCN_TESTS_LOCALIZED=ON \
+          cmake -G Ninja -DSCN_WERROR=ON -DSCN_TESTS_LOCALIZED=ON \
                 -DCMAKE_CXX_STANDARD=${{ matrix.std }} \
                 $GITHUB_WORKSPACE
 
@@ -80,6 +82,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: cmake -E make_directory ${{ runner.workspace }}/build
@@ -88,7 +92,7 @@ jobs:
         working-directory: ${{ runner.workspace }}/build
         shell: bash
         run: |
-          cmake -A ${{ matrix.platform }} -DSCN_CI=ON $GITHUB_WORKSPACE
+          cmake -A ${{ matrix.platform }} $GITHUB_WORKSPACE
 
       - name: Build
         working-directory: ${{ runner.workspace }}/build
@@ -109,6 +113,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: |
@@ -119,7 +125,7 @@ jobs:
         env:
           CXX: ${{ matrix.cxx }}
         run: |
-          cmake -DSCN_CI=ON -DCMAKE_CXX_STANDARD=${{ matrix.std }} $GITHUB_WORKSPACE
+          cmake -DSCN_WERROR=ON -DCMAKE_CXX_STANDARD=${{ matrix.std }} $GITHUB_WORKSPACE
 
       - name: Build
         working-directory: ${{ runner.workspace }}/build

diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
@@ -36,6 +36,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: |

diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
@@ -31,6 +31,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: cmake -E make_directory ${{ runner.workspace }}/build
@@ -64,6 +66,8 @@ jobs:
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Create Build Environment
         run: cmake -E make_directory ${{ runner.workspace }}/build
@@ -121,6 +125,8 @@ jobs:
 
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          submodules: recursive
 
       - name: Build and test
         run: |

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,4 +1,4 @@
-cmake_minimum_required(VERSION 3.4)
+cmake_minimum_required(VERSION 3.5)
 
 project(scn CXX)