Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for some errors #33

Open
hitchhooker opened this issue Mar 23, 2023 · 0 comments
Open

fixes for some errors #33

hitchhooker opened this issue Mar 23, 2023 · 0 comments

Comments

@hitchhooker
Copy link

vercel had some errors when building

11:45:44 PM [vite-plugin-svelte] /src/components/ImageComparison.svelte:20:2 A11y: Screenreaders already announce <img> elements as an image.
18:
19: <div class="relative overflow-hidden border-gray-300 rounded">
20:   <img class="w-full block" src="{bottomImageUrl}" alt="Bottom Image" />
      ^
21:   <div bind:this="{imageComparisonTop}" class="absolute top-0 left-0 overflow-hidden image-comparison-top">
22:     <img class="w-full block" src="{topImageUrl}" alt="Top Image" />
11:45:44 PM [vite-plugin-svelte] /src/components/ImageComparison.svelte:22:4 A11y: Screenreaders already announce <img> elements as an image.
20:   <img class="w-full block" src="{bottomImageUrl}" alt="Bottom Image" />
21:   <div bind:this="{imageComparisonTop}" class="absolute top-0 left-0 overflow-hidden image-comparison-top">
22:     <img class="w-full block" src="{topImageUrl}" alt="Top Image" />
        ^
23:   </div>
24:   <input
11:45:44 PM [vite-plugin-svelte] /src/components/Tag.svelte:1:0 A11y: visible, non-interactive elements with an on:click event must be accompanied by an on:keydown, on:keyup, or on:keypress event.
1: <span
   ^
2:   class={`font-heading font-medium ${variant === "ghost" ? "bg-rose-100 text-rose-700" : "shadow-sharp border-2 border-rose-900 bg-white text-zinc-900"} text-sm no-underline gap-2 py-1 px-2 mt-2 uppercase transition-property-filter duration-200 ease-out cursor-pointer`}
3:   tabindex="0"
11:45:44 PM [vite-plugin-svelte] /src/components/Tag.svelte:1:0 A11y: noninteractive element cannot have nonnegative tabIndex value
1: <span
   ^
2:   class={`font-heading font-medium ${variant === "ghost" ? "bg-rose-100 text-rose-700" : "shadow-sharp border-2 border-rose-900 bg-white text-zinc-900"} text-sm no-underline gap-2 py-1 px-2 mt-2 uppercase transition-property-filter duration-200 ease-out cursor-pointer`}
3:   tabindex="0"
11:45:44 PM [vite-plugin-svelte] /src/components/Posts.svelte:19:5 A11y: visible, non-interactive elements with an on:click event must be accompanied by an on:keydown, on:keyup, or on:keypress event.
17:       {#if uniqueTags.length > 0}
18:         {#each uniqueTags as tag}
19:           <span
              ^
20:             class="block text-left font-heading text-lg p-2 cursor-pointer transition-property-all ease-out duration-100 hover:text-white hover:bg-rose-900"
21:             on:click={() => {
11:45:46 PM [build] Completed in 2.87s.

 building client
transforming (1) node_modules/.pnpm/@[email protected]_srabkpdrmffps2vsyx2my6v6uy/node_modules/@astrojs/svelte/client.js11:45:46 PM [vite-plugin-svelte] /src/components/Posts.svelte:19:5 A11y: visible, non-interactive elements with an on:click event must be accompanied by an on:keydown, on:keyup, or on:keypress event.
17:       {#if uniqueTags.length > 0}
18:         {#each uniqueTags as tag}
19:           <span
              ^
20:             class="block text-left font-heading text-lg p-2 cursor-pointer transition-property-all ease-out duration-100 hover:text-white hover:bg-rose-900"
21:             on:click={() => {
transforming (3) node_modules/.pnpm/[email protected]/node_modules/svelte/transition/index.mjs11:45:46 PM [vite-plugin-svelte] /src/components/Tag.svelte:1:0 A11y: visible, non-interactive elements with an on:click event must be accompanied by an on:keydown, on:keyup, or on:keypress event.
1: <span
   ^
2:   class={`font-heading font-medium ${variant === "ghost" ? "bg-rose-100 text-rose-700" : "shadow-sharp border-2 border-rose-900 bg-white text-zinc-900"} text-sm no-underline gap-2 py-1 px-2 mt-2 uppercase transition-property-filter duration-200 ease-out cursor-pointer`}
3:   tabindex="0"
11:45:46 PM [vite-plugin-svelte] /src/components/Tag.svelte:1:0 A11y: noninteractive element cannot have nonnegative tabIndex value
1: <span
   ^
2:   class={`font-heading font-medium ${variant === "ghost" ? "bg-rose-100 text-rose-700" : "shadow-sharp border-2 border-rose-900 bg-white text-zinc-900"} text-sm no-underline gap-2 py-1 px-2 mt-2 uppercase transition-property-filter duration-200 ease-out cursor-pointer`}
3:   tabindex="0"

some fixes:

# Fix ImageComparison.svelte alt attributes
rg -l 'alt="Top Image"' src/components/ImageComparison.svelte | xargs perl -i -pe 's/alt="Top Image"/alt="Top"/g'
rg -l 'alt="Bottom Image"' src/components/ImageComparison.svelte | xargs perl -i -pe 's/alt="Bottom Image"/alt="Bottom"/g'

# Change tabindex to -1 in Tag.svelte
rg -l 'tabindex="0"' src/components/Tag.svelte | xargs perl -i -pe 's/tabindex="0"/tabindex="-1"/g'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant