Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubCollection does not create #38

Closed
elersong opened this issue Jul 13, 2024 · 1 comment
Closed

SubCollection does not create #38

elersong opened this issue Jul 13, 2024 · 1 comment
Labels
bug Something isn't working can't reproduce Bug can't be identified in current code from_willyovale An issue described in original project, but never implemented

Comments

@elersong
Copy link
Owner

darmie commented on Oct 2, 2022

subCollection.create does not create the subcollection inside of the parent collection.

This used to work before, I am not sure what changed.

Original Issue

@elersong elersong added bug Something isn't working from_willyovale An issue described in original project, but never implemented labels Jul 13, 2024
@elersong
Copy link
Owner Author

elersong commented Jul 15, 2024

Found in /test/functional/3-subcollections.spec.ts

    const batch = repo.albums.createBatch();

    await rush.albums.create(secondAlbum);
    batch.create(fourthAlbum);
    batch.create(eighthAlbum);

    await batch.commit();

The jest test shows that the secondAlbum record gets created and is queryable.

As of 6ad447a I can't reproduce this problem. The integration test suggests this functionality is operational.

@elersong elersong added the can't reproduce Bug can't be identified in current code label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working can't reproduce Bug can't be identified in current code from_willyovale An issue described in original project, but never implemented
Projects
None yet
Development

No branches or pull requests

1 participant